Scroll and add back arrows

[Valdnet]

The bug and improvement described in Issue #32.

[ManeraKai]

Changed the scrolling behavior, but didn't add a back button because that screen is meant to take as much space as possible. Google Translate's maximized screen doesn't have any button. Just text. What do you think @Valdnet @Aga-C?

[Aga-C]

You have 4 buttons, why not add another one here?

[ManeraKai]

So not an appBar, but on that column? Interesting

[Valdnet]

You have 4 buttons, why not add another one here?

It can be placed there, but first in order (top) 😉.

[Aga-C]

So not an appBar, but on that column? Interesting

No, I didn't mean to add a bar on top. In the original comment I wrote about three things:

• text is too close to notification bar (phone one) and it would be good to add some space from top
• buttons shouldn't scroll with text
• there should be another button for going back (in the same column as other buttons), e.g. close_fullscreen from Material

[ManeraKai]

OK: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1381172677

[Valdnet]

You cannot see the slider while scrolling the text.

[Valdnet]

And there is this to be implemented for this window along with text selection (so that it doesn't scroll when selected) 😁.

[ManeraKai]

It really doesn't have a bug there because the input is talking all the screen. Maybe it's color is just white.

[Valdnet]

It really doesn't have a bug there because the input is talking all the screen.

👍

Maybe it's color is just white.

You have to change to green 😉.

[Aga-C]

Looks good. From things I described, only space from the top is still missing:

As you can see, the border of the window is overlapping icons in my notifications bar.

[Valdnet]

As you can see, the border of the window is overlapping icons in my notifications bar.

It is displayed correctly for me. This can only be a problem with some smartphones. @ManeraKai you need to look at it better 😉.

[ManeraKai]

This can only be a problem with some smartphones.

Yes, this works for me too. I may hide the status bar @Aga-C.

[Aga-C]

Yes, this works for me too. I may hide the status bar @Aga-C.

It would be the best idea 🙂

BTW. The same was happening on an emulator:

[ManeraKai]

I use the Pixel XL API 29 emulator.

[Aga-C]

I use Pixel 5 API 30.

[ManeraKai]

Lets see: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1381389736

[ManeraKai]

Forgot to change the color of the text selection toolbar though.

[Aga-C]

Just some small cosmetic issue: if there's now no status bar, it would be better to move everything a bit to the top. Especially that, at the bottom, the border is too close to the bottom of the screen. E.g. on my phone with rounded corners, border corners are sticking to the rounded edge of the screen (unfortunately I can't show this on a screenshot).

[ManeraKai]

Changed it.

[Aga-C]

The bottom part looks good, but I'd reduce a space a bit at the top.

[ManeraKai]

Doesn't having it as a symmetric center box better?

[Aga-C]

Doesn't having it as a symmetric center box better?

Ok, I've run it on a real phone, not on an emulator, and it looks good.

So, for me, now this feature looks and works as it should. Thanks! 🙂