ManeraKai / simplytranslate_mobile

Privacy friendly frontend to Google Translate
https://manerakai.github.io/simplytranslate_mobile/
GNU General Public License v3.0
173 stars 15 forks source link

New release 1.1.3 #158

Closed Valdnet closed 2 years ago

Valdnet commented 2 years ago

Tasks to be performed for version 1.1.3:

@ManeraKai I think it's time to release a new version with fixed bugs and additional features 😉.

Valdnet commented 2 years ago

@ManeraKai I think you can update the translation from POEditor if there is a new one and release a new version. Issue #61 has been shifted for v1.1.4 for an obvious reason 😉.

ManeraKai commented 2 years ago

I did update POEditor a few days ago, I should check it again though. I'll release a new version once I finish my exams. 3 left for 3 days.

ManeraKai commented 2 years ago

Did a scan to clean the code. Updated translations. Fixed bugs. Almost ready. Any bug on your side @Valdnet?

ManeraKai commented 2 years ago

https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1456830351

Valdnet commented 2 years ago

The icon for a light theme should be of a different color. Currently confusing the user a bit.

ManeraKai commented 2 years ago

Any suggestion?

Valdnet commented 2 years ago

Maybe yellow?

ManeraKai commented 2 years ago

Yellow doesn't contrast at all with white, I think I tried that, works well with dark mode though.

ManeraKai commented 2 years ago

A dimmed yellow maybe?

ManeraKai commented 2 years ago

https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1457412702

Valdnet commented 2 years ago

You need to change the font color in the theme picker for dark theme.

ManeraKai commented 2 years ago

Changed: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1458727811

Valdnet commented 2 years ago

Error build.

ManeraKai commented 2 years ago

Idk what's wrong, reran it: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1458880402

Valdnet commented 2 years ago

There are 4 strings in POEditor that have no text to translate:

obraz

ManeraKai commented 2 years ago

They are not in the .arb files, I'll fix them but they don't have an effect on our release I think.

Valdnet commented 2 years ago

Change the font color from black to white in the theme selector for the dark theme:

obraz

ManeraKai commented 2 years ago

Fixed.

Valdnet commented 2 years ago

These text strings should be added to the translation:

https://github.com/ManeraKai/simplytranslate_mobile/blob/8c08cf015dbf166366d277edbcb8dbaf05a121af/lib/screens/about/about_screen.dart#L89

https://github.com/ManeraKai/simplytranslate_mobile/blob/8c08cf015dbf166366d277edbcb8dbaf05a121af/lib/screens/about/about_screen.dart#L117

ManeraKai commented 2 years ago

They're brand names. i.e: Buy me a coffee has it's domain name as https://www.buymeacoffee.com/

Valdnet commented 2 years ago

Can there be Arabic letters or a text string as RTL in other languages, such as Arabic?

ManeraKai commented 2 years ago

Your right, checked https://www.buymeacoffee.com/, didn't have an Arabic name. Checked https://liberapay.com/, it has an Arabic name ليبرا باي

Valdnet commented 2 years ago

I would also add: Buy me a coffee. It is not known how it occurs in other languages 😉.

ManeraKai commented 2 years ago

It's untranslated now in their website. If it gets translated, I'll added it 👍

Valdnet commented 2 years ago

Still need to change to about_screen.dart.

ManeraKai commented 2 years ago

oh I forgot.

ManeraKai commented 2 years ago

Fixed.

ManeraKai commented 2 years ago

@Valdnet I'll release the version. Hope you're still alive.

Valdnet commented 2 years ago

@ManeraKai Of course, release the new version :+1:.

Hope you're still alive.

I am 😉.

Aga-C commented 2 years ago

Well done, guys 🙂 BTW. The website is really nice too 👍

Valdnet commented 2 years ago

Yesterday a new version of the application was released 😁.

Well done, guys

@Aga-C Thanks 😉.

ManeraKai commented 2 years ago

And polish: https://f-droid.org/pl/packages/com.simplytranslate_mobile/ It looks off, zoom to 90% in a 1920:1080 display to make it look good.

ManeraKai commented 2 years ago

Talking about the web version of the f-droid site, it's totally ruined in the f-droid app. context:

|--------------------|
| Talking about this |
|--------------------|
Valdnet commented 2 years ago

It doesn't look good. I'd rather give it up.

ManeraKai commented 2 years ago

Sadly

Valdnet commented 2 years ago

On the application page, you need to update the screenshots 😉.

ManeraKai commented 2 years ago

Yeah I noticed that. Updated them 3 days ago: https://github.com/ManeraKai/simplytranslate_mobile/commit/91a0f9ee5edb1c7a4a0943aea81c80d1367f7b10

Valdnet commented 2 years ago

I'm talking about the screenshots on the website, not GitHub.

ManeraKai commented 2 years ago

Updated them: https://github.com/ManeraKai/simplytranslate_mobile/commit/55124ae2847fd72e7f2fcf83388dc821c8503b4d