ManeraKai / simplytranslate_mobile

Privacy friendly frontend to Google Translate
https://manerakai.github.io/simplytranslate_mobile/
GNU General Public License v3.0
173 stars 15 forks source link

Release 1.1.4 #168

Closed ManeraKai closed 2 years ago

ManeraKai commented 2 years ago

@Valdnet I think a new version should be released. Will keep working on the requested features though.

Valdnet commented 2 years ago

I think a new version can be released 😉. Among other things, new translations and corrections were added.

ManeraKai commented 2 years ago

The camera feature was added too.

Valdnet commented 2 years ago

Is this feature complete? I haven't tested the camera function yet 😁.

Valdnet commented 2 years ago

Please add the following strings to your translation:

https://github.com/ManeraKai/simplytranslate_mobile/blob/71be50117a38918f0307f854bf0c64fd8379e1cb/lib/google/widgets/translation_input/widgets/camera.dart#L88 https://github.com/ManeraKai/simplytranslate_mobile/blob/71be50117a38918f0307f854bf0c64fd8379e1cb/lib/google/widgets/translation_input/widgets/camera.dart#L92 https://github.com/ManeraKai/simplytranslate_mobile/blob/71be50117a38918f0307f854bf0c64fd8379e1cb/lib/google/widgets/translation_input/widgets/camera.dart#L101 https://github.com/ManeraKai/simplytranslate_mobile/blob/71be50117a38918f0307f854bf0c64fd8379e1cb/lib/google/widgets/translation_input/widgets/camera.dart#L120

Should be changed: Trained data files aren't installed. -> Trained data files are not installed. ${fromSelLangMap[fromLangVal]!} Text Recognition -> Text Recognition - ${fromSelLangMap[fromLangVal]!}

This variable ${fromSelLangMap[fromLangVal]!} should be simplified for translators. As was done for other text strings.

ManeraKai commented 2 years ago

Is this feature complete? I haven't tested the camera function yet grin.

Not as mature as GoogleTranslate's one, but it's good for a first release.

Valdnet commented 2 years ago

Please also add these text strings for translation:

https://github.com/ManeraKai/simplytranslate_mobile/blob/ba123f448022d6c4176beeb6c491fd088e4350a0/lib/screens/settings/widgets/text_recognition.dart#L22-L23 https://github.com/ManeraKai/simplytranslate_mobile/blob/ba123f448022d6c4176beeb6c491fd088e4350a0/lib/screens/settings/screens/text_recognition_screen.dart#L41

Not as mature as GoogleTranslate's one, but it's good for a first release.

I am testing and I am full of admiration 😉.

ManeraKai commented 2 years ago

This variable ${fromSelLangMap[fromLangVal]!} should be simplified for translators. As was done for other text strings.

Simplified it to Text Recognition - $language

Valdnet commented 2 years ago

Simplified it to Text Recognition - $language

In the arb files, the text string must be changed to the correct one.

https://github.com/ManeraKai/simplytranslate_mobile/blob/8ca24c7b3fd4d31819040bd382ff7237c763f357/lang/main_en.arb#L166

ManeraKai commented 2 years ago

Didn't commit it yet.

ManeraKai commented 2 years ago

Matured the camera too. Anything else @Valdnet. This release is just for F-Droid users to keep up. I will complete working on the other things.

Valdnet commented 2 years ago

Before releasing a new version, remember to merge #167. And should be improved yet https://github.com/ManeraKai/simplytranslate_mobile/issues/169#issuecomment-1013905080.

Aga-C commented 2 years ago

The Translation section on the website should be updated to contain the link to Weblate 🙂

Valdnet commented 2 years ago

On the application page, you also need to change the link to Weblate.

ManeraKai commented 2 years ago

@Valdnet @Aga-C updated the links in the app and website.

ManeraKai commented 2 years ago

Added the site's translation strings to Weblate too.

Aga-C commented 2 years ago

@ManeraKai I've just noticed that some strings I've changed for website and main on Weblate have been reverted to old versions. I've just fixed them again, but why did it happen?

ManeraKai commented 2 years ago

Oh, I think because I reseted it. Really sorry for that.

Aga-C commented 2 years ago

Ok, no problem. It was easy to revert it 🙂

ManeraKai commented 2 years ago

I'll just fix some things in the website and we're ready to go!

Valdnet commented 2 years ago

On the website, under "Want to Donate?" you have swapped links or graphics 😉.

ManeraKai commented 2 years ago

@Valdnet Fixed them and finished working with the site.

ManeraKai commented 2 years ago

Fly my Wind Assassin 🚀 https://github.com/ManeraKai/simplytranslate_mobile/releases/tag/v1.1.4

ManeraKai commented 2 years ago

One last thing if you can add the Camera Text Recognition in Polish in the metadata @Valdnet @Aga-C.

ManeraKai commented 2 years ago

Isn't it a little weird that f-droid didn't update the version?

Aga-C commented 2 years ago

Maybe you should ask them on their GitLab.