ManeraKai / simplytranslate_mobile

Privacy friendly frontend to Google Translate
https://manerakai.github.io/simplytranslate_mobile/
GNU General Public License v3.0
173 stars 15 forks source link

GUI too large. #193

Closed Git-Forked closed 2 years ago

Git-Forked commented 2 years ago

Problem:

The graphical interface is too large. This is annoying and reduces efficiency when using the app.

Possible Solution(s):

ManeraKai commented 2 years ago

When you're typing the keyboard is opened, the translate button goes up to the top part of the keyboard.

Git-Forked commented 2 years ago

That's true, but it would be more convenient and look nicer to have all of the GUI fit the screen size without having to scroll. It's only slightly too big, so why not resize it to actually fit properly?

ManeraKai commented 2 years ago

How much is your Font Size in the Accessibility options in your android? This setting resizes everything for all apps.

Git-Forked commented 2 years ago

My font is default size, but even on the smallest size, the GUI is too large for the screen.

ManeraKai commented 2 years ago

I see, I'll see what I can do.

Git-Forked commented 2 years ago

I'm going to send you some pictures, so you can see what I am seeing.

Git-Forked commented 2 years ago

Scrolled to the top:

Scrolled to the bottom:

Git-Forked commented 2 years ago

I see, I'll see what I can do.

Thank you, and I appreciate the work you have put into this app, as well as your kindness in considering my suggestion to make the app look better and fit the screen.

Git-Forked commented 2 years ago

If you package a version that fixes the issue, I will be glad to test it out for you on my device.

ManeraKai commented 2 years ago

I'm now trying to put the icons as a row as you said. But it's not working well design wise:

Everything is cramped now and it looks awful. I have an idea though.

@Valdnet I'll add a setting that is: Enable Advanced Tools. This will enable the paste, maximize, minimize icons. Those were you're request and not every user uses them. They still can be enabled though. How it may look:

What do you think @Valdnet @Git-Forked?

Valdnet commented 2 years ago

I propose to hide the character counter and add an option in the settings where the user can enable the visibility of the character counter. I think that the character counter is less needed and the user will get information about exceeding the limit anyway.

Your idea is also good, but there is a lot of unused space in the window with the translated text and the "Paste" icon is used quite often.

ManeraKai commented 2 years ago

I propose to hide the character counter and add an option in the settings where the user can enable the visibility of the character counter. I think that the character counter is less needed and the user will get information about exceeding the limit anyway.

I see.

Your idea is also good, but there is a lot of unused space in the window with the translated text and the "Paste" icon is used quite often.

How about removing the maximize, minimize buttons and keeping more tools in the input?

Valdnet commented 2 years ago

How about removing the maximize, minimize buttons and keeping more tools in the input?

I think you can opt out of these buttons. And so these buttons are in the magnified view window.

ManeraKai commented 2 years ago

I agree too.

ManeraKai commented 2 years ago
Valdnet commented 2 years ago

It looks very good in my opinion 👍.

ManeraKai commented 2 years ago

Added it, here it is: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1992543673

Git-Forked commented 2 years ago

Why do we need a copy button in the input box? Wouldn't we only need paste? Anyways both are available natively on mobile with a long press, but having the paste button seems quicker, so I don't mind that button, but copy button seems like it could be hidden most the time, and enabled with advanced options. Copy button on the result is fine though, and useful.

I'm going to install your release and check it out. Thank you.

I'm unable to install this version. I downloaded compiled-flutter-code.zip and extracted from inside it an app-development-debug.apk, but my phone refuses to install it with message: "App not installed" (And I do have "Install Unknown Apps" option enabled)

Update: After like 8 attempts it finally installed.

Still seems a slight bit too big for my screen. A 3rd of the translate button is off the screen, and there seems to be some empty blank space under it that should be cleaned up. This phone has soft navigation buttons and not hard buttons, which take up some of the bottom of the screen. So, if it could be made just a bit smaller, that would be ideal. The space above and below the language selection is more pixels than between text boxes, perhaps the margin space can be made consistent to the smaller size. Also, I'm not seeing the "advanced options" in settings. Perhaps when advanced options are there, the user could select which icons they wish to see with a tick box, and then people can customize it how they like it, since not everyone may like it the same way. We all have different uses and needs for different tools.

Thank you for the improvements.

Git-Forked commented 2 years ago

Any reason why the file is so big now? Seems it keeps growing. Moving buttons shouldn't have increased the size. v1.1.3 was 19.5 MiB v1.2.0 jumped to 79.9 MiB And this new release you posted above is 135 MB.

Valdnet commented 2 years ago

Why do we need a copy button in the input box? Wouldn't we only need paste?

The copy button is intentionally placed for the window with the text to be translated. It improves the copying of the inverted translation, which consists in the fact that the translated text re-translated into the native language allows you to check the correct translation, which can be immediately copied via the "Copy" button to the phone's memory.

I'm unable to install this version. I downloaded compiled-flutter-code.zip and extracted from inside it an app-development-debug.apk, but my phone refuses to install it with message: "App not installed" (And I do have "Install Unknown Apps" option enabled)

The downloadable application is in a debug version and is not signed. To install this version you must first uninstall the F-Droid version (but you've already dealt with that).

Any reason why the file is so big now? Seems it keeps growing. Moving buttons shouldn't have increased the size. v1.1.3 was 19.5 MiB v1.2.0 jumped to 79.9 MiB

v1.1.3 was 19.5 MiB - version without "Camera Text Recognition" v1.2.0 jumped to 79.9 MiB - version with "Camera Text Recognition"

And this new release you posted above is 135 MB.

It is a debug version, so it is much larger.

Git-Forked commented 2 years ago

Alright, thank you for answering that. Also I edited my above post to add the following:

The space above and below the language selection is more pixels than between text boxes, perhaps the margin space can be made consistent to the smaller size.

ManeraKai commented 2 years ago

We didn't add the advanced options as we settled on removing buttons from the result output. Seems we're not that settled xD and so I think I should add them as a checklist of which buttons to enable and disable. Seems every person uses translation very very differently.

ManeraKai commented 2 years ago

btw another reason why build is large is that it's compiled to multiple platforms. You can split the version to 3 seperate platforms and the size will be much smaller image Context: https://docs.flutter.dev/deployment/android#build-an-apk

Git-Forked commented 2 years ago

We didn't add the advanced options as we settled on removing buttons from the result output. Seems we're not that settled xD and so I think I should add them as a checklist of which buttons to enable and disable. Seems every person uses translation very very differently.

Yes, I think making it customizable for each person is a good idea. Thank you for considering that.

ManeraKai commented 2 years ago

This is how it looks: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/2044105216

Git-Forked commented 2 years ago

That looks really good now and it fits my screen. :D The customizable buttons are a great addition. Excellent work.

PS: Please add this version to F-Droid soon. Thank you.

ManeraKai commented 2 years ago

Nice to hear that! I'll improve on it as it breaks some other things related to the inputs, then will release it. Hopefully soon.

Valdnet commented 2 years ago

1. White icon for camera button in light theme:

obraz

2. No icon for counter settings:

obraz

3. Increase the margin for the "Input" text string:

obraz

4. All text strings should start with a capital letter:

remove -> Remove copy -> Copy camera -> Camera paste -> Paste text-to-speech -> Text-To-Speech counter -> Counter maximize -> Maximize

5. Move the "Customize Buttons" setting to the "Appearance" setting:

obraz

And do not forget to add text strings for translation 😉.

Tested on: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/2047328527.

ManeraKai commented 2 years ago
  1. White icon for camera button in light theme:

Fixed before. I think because of the version you tested as you mentioned.

  1. No icon for counter settings:

I really don't know what to add as an icon: https://fonts.google.com/icons?selected=Material+Icons

ManeraKai commented 2 years ago

https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/2053743364

Valdnet commented 2 years ago

I really don't know what to add as an icon: https://fonts.google.com/icons?selected=Material+Icons

The best icon would be the app's counter icon, but understands that it would need to be created.

My types of icons:

ManeraKai commented 2 years ago

tbh I may just make a little photo or widget containing that. All the icons are just unrepeatable. As you said it should be the app's counter icon.

OkyDooky commented 2 years ago

One option to save space is to have the "Copy" icon/button turn into the "Paste" icon/button when there is no text in the top text-box, then turn back into "Copy" when text is present. We already have the X to quickly cleae text, so that should save the step of having to "Select All" -> "Delete" any existing text.

ManeraKai commented 2 years ago

@OkyDooky That would be somewhat complex for the user. Changing buttons order will be confusing imo. What do you think @Valdnet?

Valdnet commented 2 years ago

This is some solution, but it is not best for the user. Sometimes the user needs to paste the text many times in different places, e.g. Name or the same words. Such a function with changing the button prevents this and may be a bit unintuitive and confusing for the user. I am for leaving it as it is. The ability to set buttons in the application settings is already a sufficient solution.

ManeraKai commented 2 years ago

I agree too.

Valdnet commented 2 years ago

@ManeraKai After installing the application from artifact, I noticed that the application does not remember the button display settings. After restarting the application, the new settings are ignored.

Also remember to add an icon for "Counter" 😉.

ManeraKai commented 2 years ago

committed here: https://github.com/ManeraKai/simplytranslate_mobile/commit/1f608a7960dcc69e2d13aaf48752b8ece927a13b

ManeraKai commented 2 years ago

https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/2194473452

Valdnet commented 2 years ago

Is this normal in the debug version?

obraz

ManeraKai commented 2 years ago

Uninstall it completely with deleting the cache and try again. This is weird.

Valdnet commented 2 years ago

The application was previously uninstalled.

Valdnet commented 2 years ago

This issue persists in the latest debug version.

ManeraKai commented 2 years ago

Yesterday I found out why. I just didn't push the pubspec.yaml file. I pushed the changes yesterday. https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/2233975339