search

ManeraKai / simplytranslate_mobile

Privacy friendly frontend to Google Translate
https://manerakai.github.io/simplytranslate_mobile/
GNU General Public License v3.0
173 stars 15 forks source link

Add a tab navigation for different engines #31

Closed Aga-C closed 3 years ago

Aga-C commented 3 years ago

Hi,

I think that it would look better if separate translation engines would be chosen not on a bottom of the page, but at the top. The best in my opinion would be a tab navigation, something like here: https://blog.logrocket.com/flutter-tabbar-a-complete-tutorial-with-examples/. Something similar is also in a web client.

It would be good not only from UX view, but also you can narrow functionalities. For example, LibreTranslate doesn't support as many languages as Google Translate, so you can do language filtering for the proper page.

ManeraKai commented 3 years ago
  1. Do you prefer this approach, or having an app menu and a separate settings page. Because we're gonna make an about page for this issue #23.
  2. For filtering supported languages, I totally forgot about that.
Aga-C commented 3 years ago

I prefer this approach - GoogleTranslate and LibreTranslate in separate tabs. And the option to set an instance could be available in settings from the app menu.

ManeraKai commented 3 years ago

I've added now tabs for Google and Libre. Libre won't be available if it's not supported on instance. FromLang, ToLang, and TranslationInput have the same values on both tabs, TranslationOutput is not the same though. Everything else is just weirdly working fine. Too quite to be true.

Aga-C commented 3 years ago

Thanks, it looks ok.