"Enter" as line break

[Valdnet]

When writing the text to be translated, the "Enter" key should start a new line of writing. Currently, it starts translating immediately.

[ManeraKai]

Thought of this. Either you have the Enter key or Auto Translating. You can't live without one of them.

[Valdnet]

I don't know if we understood each other well.

"Enter" - new line "Translate" - translation

[ManeraKai]

Enter means submitting the form so translating

A quote from my brain dictionary

I think you meant to change Enters key functionality from submitting to adding a new line?

[Valdnet]

I think you meant to change Enters key functionality from submitting to adding a new line?

Yes :+1:.

[ManeraKai]

@Valdnet It'll be done like that: https://github.com/ManeraKai/simplytranslate-flutter-client/pull/40#issuecomment-922257911

[ManeraKai]

Changed it. Added a float button for translation:

[ManeraKai]

Any design issue will be discussed here #33

[Valdnet]

The "Enter" key on the keyboard does not work. After tapping a key, it does not start a new line.

[ManeraKai]

Working fine on my emulator. Downloaded last artifact to my real device. Working fine too.

[Valdnet]

On my Android 10 smartphone, something like this is happening:

[ManeraKai]

Try to restart the device. I know one thing that may be causing this problem.

[Valdnet]

Try to restart the device.

Did not help. There is something in the application 😉.

[ManeraKai]

Hope it works: https://github.com/ManeraKai/simplytranslate-flutter-client/actions/runs/1275434226

[Valdnet]

No change. The "Enter" key still does not work.

[ManeraKai]

Can you try it on another device, because I really didn't change anything.

[Valdnet]

Previously, it worked on my smartphone 😁.

[ManeraKai]

One minute. Do the previous artifacts work fine at the moment?

[Valdnet]

The artefact Flutter build apk #50 does not work properly.

[Valdnet]

Maybe this commit did something wrong: https://github.com/ManeraKai/simplytranslate-flutter-client/commit/419982cfeb5f4fd230d7245a2c2a07ebf5332247.

[ManeraKai]

This commit was about the TextSelectionToolbar

[Valdnet]

Other commits would probably not spoil it.

[ManeraKai]

Let me try to comment the customization of the TextSelectionToolbar and see what happens.

[ManeraKai]

TextSelectionToolbar is disabled: https://github.com/ManeraKai/simplytranslate-flutter-client/actions/runs/1275539214

[Valdnet]

There is still a problem 😬.

[Valdnet]

For black theme, a gray frame appears around the window when I tap the "Enter" key. Maybe it will help?

[Valdnet]

This frame can be the glow of that gray background that appears in a light theme.

[ManeraKai]

Try to paste multi line text

[Valdnet]

Try to paste multi line text

I can paste without any problem.

[ManeraKai]

So you can paste. Can you add a new line or what can you and can't you do now?

[Valdnet]

If I paste a new line, I can only delete it.

[ManeraKai]

Can you try to change from Swift keyboard to the stock one.

[ManeraKai]

btw I meant pasting from the toolbar options. Not from the side buttons.

[Valdnet]

I can paste new lines from the toolbar and just delete them.

I noticed that when I type a space character tapping the "Enter" key removes it. If he enters several space characters, he removes them one by one each time he taps the "Enter" key, until it encounters a character, e.g. letters or numbers.

[Valdnet]

When removing the space characters with the "Enter" key, there is still a glow in the window, which I showed above in the screenshot.

[Valdnet]

Can you try to change from Swift keyboard to the stock one.

I don't have another keyboard in my system.

[Valdnet]

When selecting a language from the list of languages, the "Enter" key works correctly. Selects the given language.

[ManeraKai]

I'll disconnect the controller for that TextField. So You'll have just a vanilla multi-line TextField to type in, without character limit or anything like that.

[ManeraKai]

Or one minute, my emulator doesn't detect my keyboard Enter key. When I disabled the custom TextSelectionToolbar, I forgot that the textfield was wraped by a TextSelectionToolbarTextButton widget: Going to delete that and see, but this will disable the custom TextSelectionToolbar.

[ManeraKai]

The glow even appeared for me too.

[ManeraKai]

I'm confident it will work: https://github.com/ManeraKai/simplytranslate-flutter-client/actions/runs/1275877228

[Valdnet]

It works in this version 👍.

[ManeraKai]

Means that it's because of the custom TextSelectionToolbar

[Valdnet]

You mean we can't use it?

And there will still be a problem with issue #61.

[ManeraKai]

Issue #61 is not a critical one as this issue. I'll find a fix for it, but we should get a release running at the time, because there has been so many changes done. Some Instances have even changed their domain name. We don't have time.

[Valdnet]

Well. Release a new version 😉.

Check also PR #109.

[ManeraKai]

Check also PR #109.

I've added some comments.