search

ManeraKai / simplytranslate_mobile

Privacy friendly frontend to Google Translate
https://manerakai.github.io/simplytranslate_mobile/
GNU General Public License v3.0
173 stars 15 forks source link

add the option to select the translation engine #4

Closed darhma closed 3 years ago

darhma commented 3 years ago

From the website https://translate.metalune.xyz/ you can select the translation engine (google/libretranslate) it would be useful to add a similar option in the app as well.

ManeraKai commented 3 years ago

I'm adding query parameters to the url for selecting the engine. But it gives me an error: image

I tried to use twitter's server and added the lang parameter to see if the UI language will change and it worked just fine: Arabic: image Spanish: image

Note that if I changed the parameter to anything other than libre, it won't give an error and will translate the text: image Maybe it's a server side problem.

ManeraKai commented 3 years ago

Update: it's now weirdly working just fine. Too quiet to be believed. Don't know what happened: image

darhma commented 3 years ago

I tried to enter https://metalune.xyz/?engine=libre as a custom server but it didn't work.

ManeraKai commented 3 years ago

You forgot the subdomain translate: https://translate.metalune.xyz/?engine=libre

darhma commented 3 years ago

I just tried again with https://translate.metalune.xyz/?engine=libre but it still doesn't work.

ManeraKai commented 3 years ago

I think it's because I didn't add support for parameters. If you inject it in the code though. It will work. I'm now working on it.

ManeraKai commented 3 years ago

Note: If the instance didn't have LibreTranslate turned on. The client won't detect that yet.

ManeraKai commented 3 years ago

I've now added LibreTranslate detection.

darhma commented 2 years ago

I am trying the app again but I don't understand how to select LibreTranslate as the translation engine, even using an instance that supports it like https://simplytranslate.org/ it is still possible to select a different engine or it is a feature that has been deleted?

ManeraKai commented 2 years ago

The support for an engine other than GoogleTranslate has been removed. We'll readded though. There were so many bugs and collisions that we needed to remove it.

darhma commented 2 years ago

Thanks for the answer, I had imagined that the implementation could present some problems and that it had been removed for this. A little sorry about that but you have made an understandable choice, in any case the app seems to work well so keep up your good work. Thanks