Closed Valdnet closed 1 year ago
Reverted it back. Let's see now if that weird anonymous problem that happened to your device before is present now.
Now it works fine. The "Enter" key also works fine.
Will you correct it?
The height of the text windows.
I've purposely made them longer. I'll shorter them.
No text scroll bar.
👍
The height of the text windows.
Or can they be responsive based on screen's height?
Added a Scrollbar and made the heights responsive so they will fit every screen-size: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1342514385
Or can they be responsive based on screen's height?
Good idea, only with a minimum height so that the windows are not too small on a very small display (visibility of icons).
It looks pretty good now 😁.
Should be corrected:
The text should automatically scroll to the last line.
The first time you select it, the text escapes up or down. Sometimes the entire text window also escapes.
And what are these buttons for?
The shadow with these buttons interferes with writing text in the horizontal position of the smartphone.
Paste text using the "Paste" icon.
Fixed.
The first time you select it, the text escapes up or down. Sometimes the entire text window also escapes.
How? Nothing happens to mine if I understood.
And what are these buttons for?
They here because I've added an extension. Tried to get rid off them but didn't find them. Will try again.
Found them:
How? Nothing happens to mine if I understood.
But it is surprising and annoying for the user 😬.
Steps:
The first time you select it, the text escapes up or down.
When you start the application for the first time and paste and select text.
You have an active bar when you start it for the first time.
Also remove this shadow on the keyboard. Does not match the application and it interferes with horizontal editing of the window.
Sorry it took long to remove the shadow, but things were behaving weird: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1344843260
Does the first issue still happens with this build? Clearing Cache something anything?
Sorry it took long to remove the shadow, but things were behaving weird:
Relax, I waited patiently 😉.
Does the first issue still happens with this build?
Yes.
Did this escaping behavior happened before we added this feature?
Not. Before it was fine.
Tried to reproduce it on my device, no hope.
We'll try somethings, does this work?: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1345019159
All problems persist 😬.
Does this happen when you use the normal text-selection toolbar?
Yes. It also happens when I use the normal text editing bar in this application (version 1.1.2).
So you're saying that this is happening before we added this feature?
So you're saying that this is happening before we added this feature?
Yes. Only now did I notice it 😁.
I also thought it was a problem with the added feature 😉.
Now temporarily I've disabled all the logic that get triggered when you change the text: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1345226595
Still the same bugs 😬.
I have checked in version 1.1.1, this problem is also there.
That's weird. @Valdnet are you sure nothing is wrong with your device?
I've found that this problem only happens when the text cursor is outside the edit window while selecting.
If the cursor is in the field of view of the window, the text selection is correct.
are you sure nothing is wrong with your device?
I think not. I can check on another application 😉.
I've found that this problem only happens when the text cursor is outside the edit window while selecting.
If the cursor is in the field of view of the window, the text selection is correct.
I remember an issue that's something like this with the tear icon and the keyboard. those wrere your issues too, didn't happen to me.
I think not. I can check on another application wink.
Check another device if you can.
The problem is also that when I select the text and then I put the smartphone to sleep. After he wakes up, the text window slips up.
Check another device if you can.
Currently, I do not have this option. But I will find out from another user of the application and let you know 😉.
And did you check with the cursor position:
I've found that this problem only happens when the text cursor is outside the edit window while selecting. If the cursor is in the field of view of the window, the text selection is correct.
The best solution is to have the cursor positioned automatically in a visible place in the window when the text is scrolled. This is also how other applications are resolved.
Summary:
I have checked and confirmed. When text is selected, the text automatically scrolls to the line where the text cursor was 😁.
In your videos above it is that you first click on the text (the text editing cursor is visible) and then select the text. That is why this is not the case with you.
But I will find out from another user of the application and let you know 😉.
So far I can't confirm with another user.
And did you check with the cursor position:
I've found that this problem only happens when the text cursor is outside the edit window while selecting. If the cursor is in the field of view of the window, the text selection is correct.
ooh yeah! the key was found. Apparently, you select by long pressing instead of tap tapping:
ooh yeah! the key was found.
👍 👍 👍
Apparently, you select by long pressing instead of tap tapping:
Yes 😉.
To be in context. I can detect user scrolling, but I'm now trying to calculate the cursor's position. You should take in mind if there is a line break in the text, a word overflow that created a new line. Because the cursors position is based on just letters and not lines.
As we now know what is the cause, you may need to find the cause of it. Then you don't have to implement all of this :wink:.
The only solution is to keep the cursor in view, right?
You could say so. But doesn't that trigger some function that sets the text to the position of the cursor?
I mean it's the cursor, of course new text will be written from that point.
Well let's see if this workaround works: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1347986379 It doesn't need any formulae. Just playing with selection values.
No change. The behavior is still the same.
The paste button escape correction will work here: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1348736133
It works very well :+1: :+1: :+1:.
Do not forget yet to correct the disappearance of the text editing bar when the text is selected and you will delete the text by the "Delete" button.
Do not forget yet to correct the disappearance of the text editing bar when the text is selected and you will delete the text by the "Delete" button.
Simple FocusScope.of(context).unfocus();
will do the trick: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1348829398
There is also a problem with pasting text from the text editing bar.
?
Then there is also a text selection problem. The text automatically scrolls.
Steps:
The selection menu with the "tear" is visible outside the text window: