ManevilleF / hexx

Hexagonal tools lib in rust
Apache License 2.0
288 stars 23 forks source link

add `bevy_reflect` feature + fix `serde` feature use in hex module #100

Closed uvizhe closed 1 year ago

uvizhe commented 1 year ago

This adds bevy_reflect feature as requested in #98.

Also I found old ser_de is not changed to serde in Hex.

uvizhe commented 1 year ago

Shell I commit to a changelog as well?

ManevilleF commented 1 year ago

Shell I commit to a changelog as well?

The CI is failing because:

ManevilleF commented 1 year ago

Very useful, and I firmly agree that this should be off by default.

When bevy reflection improves this wil probably be removed entirely and replaced by a bevy_hexx plugin

uvizhe commented 1 year ago

Hmm, looks like adding bevy_reflect dev dependency solves the issue with mesh_builder example. Should I add it?

I'm not sure why there's a problem at all. I appreciate it if someone will explain it to me.

ManevilleF commented 1 year ago

Hmm, looks like adding bevy_reflect dev dependency solves the issue with mesh_builder example. Should I add it?

I'm not sure why there's a problem at all. I appreciate it if someone will explain it to me.

That's a weird issue, I cloned your branch and had no issue compiling the examples, I don't understand why this is happening either. @alice-i-cecile Do you have any idea ?

uvizhe commented 1 year ago

@ManevilleF have you tried to remove your Cargo.lock?

alice-i-cecile commented 1 year ago

Yeah my guess is caching weirdness leading to inconsistent results.

ManevilleF commented 1 year ago

@uvizhe could you try and rebase om main to apply the changes of #101 ? It seems #99 introduced a compilation problem which might be related to that issue with bevy_reflect

ManevilleF commented 1 year ago

I fixed the example and the missing feature. Everything should work now, I wait for the CI and I merge this