Closed Netzwerk2 closed 1 year ago
Nice catch, that should be easy enough to fix soon.
What are the consequences of this? Is the lighting affected ?
I didn't test it, but yes it should affect lighting in bevy.
In my case I want to reflect a vector with respect to the normal, which gives wrong results if the normal isn't a unit vector.
@alice-i-cecile Have you noticed lighting issues in Emergence ? Does #109 bring any visual change to the game ?
@Netzwerk2 Could you check if #109 fixes the issue for you ?
Yes, it works as expected now.
Describe the bug The normals generated by
ColumnMeshBuilder
are not unit vectors.To Reproduce
Expected behavior All normals should be of length 1.
Screenshots Or Code snippet
Actual output
``` 1.7320508 1.7320508 1.7320508 1.7320508 1.7320509 1.7320509 1.7320509 1.7320509 1.7320508 1.7320508 1.7320508 1.7320508 1.7320508 1.7320508 1.7320508 1.7320508 1.7320509 1.7320509 1.7320509 1.7320509 1.7320508 1.7320508 1.7320508 1.7320508 1 1 1 1 1 1 1 1 1 1 1 1 1 1 ```