ManevilleF / hexx

Hexagonal tools lib in rust

Apache License 2.0

276 stars 22 forks source link

Mesh can be scaled #121

Closed ManevilleF closed 9 months ago

ManevilleF commented 9 months ago

Closes #120

Work done

Added PlaneMeshBuilder::with_scale option to scale generated mesh
Added ColumnMeshBuilder::with_scale option to scale generated mesh

The scale factor is applied before the rotation and offset, and I don't know if the API is clear enough or if it's the right way to do it. Maybe it should be called local_scale ?

ManevilleF commented 9 months ago

I think I should respect the SRT transform order, what do you think @alice-i-cecile ? I don't know how bevy does it though, I'd rather use the same order

alice-i-cecile commented 9 months ago

Yep, we should match Bevy. IIRC that's SRT. See https://github.com/bevyengine/bevy/issues/1755

ManevilleF commented 9 months ago

Done ! Looks good imo