to/from_u64: explicitly convert to little-endian

ManevilleF / hexx

Hexagonal tools lib in rust

Apache License 2.0

276 stars 22 forks source link

to/from_u64: explicitly convert to little-endian #172

Closed SIGSTACKFAULT closed 2 months ago

SIGSTACKFAULT commented 2 months ago

Someone might send these across the network... to an IBM System/390 or a spacecraft running LEON. Will that literally ever happen? probably not. But now the byte order won't get messed up!

SIGSTACKFAULT commented 2 months ago

I'm not entirely convinced a changelog entry for this is necessary since the feature wasn't released and (within a rounding error) it affects 0% of deployments

SIGSTACKFAULT commented 2 months ago

Wait i'm not sure this is necessary at all

SIGSTACKFAULT commented 2 months ago

yeah if you're sending this over the net you would want to change the endianness of the whole u64