search

MangaManagerORG / Manga-Manager

Manga Manager collects useful tools to make managing your manga library easy. (Acts directly on files)
GNU General Public License v3.0
190 stars 18 forks source link

after generated, the folder name with chinese characters become garbled #170

Open tmrsm opened 1 year ago

tmrsm commented 1 year ago

If a compressed file handled by mangamanager contains a folder name with Chinese characters(BIG5 or GBK), the folder name will become garbled after generated the comicinfo.

---2023/4/5 edited--- After conducting some tests, it was found that manga manager decompresses using encoding 437, but compresses using the local computer's encoding (in my example, it is BIG5:950), which results in the errors mentioned above.

majora2007 commented 1 year ago

Can you provide the folder name characters you're using so I can try and reproduce?

tmrsm commented 1 year ago

folder name characters is 測試

My steps for reproduction are: 1 Create a folder named 測試. 2 Compress it using 7z into 測試.zip (code page: 950). 3 rename zip to cbz 4 Use MM to generate an XML file with the volume set to 1 and no other parameters set. 5 Open the compressed file, and the folder name changes to ┤·╕╒ instead of 測試.

ivensfor commented 1 year ago

I have also encountered this issue, looking forward to a fix. Thanks.

ThePromidius commented 1 year ago

Can't reproduce

ThePromidius commented 1 year ago

2e067788 added some code to use original compression type when writing. Might want to try to reproduce since then.

tmrsm commented 1 year ago

Thank you for your reminder, but the same issue still persists in v1.0.3.