In original code there are a few issues, preventing the Series Title Language setting from operating as expected.
The romaji_as_series variable is hard-coded to True
There is not logic to handle the "Always" condition -- Romaji->Series when no English
There was also another issue, where after modifying settings in the UI:
save_settings() is called and updates the instance's settings
get_cinfo() is a class method and cannot read the updated saved settings. So settings update in the UI on the AniList provider but do not take effect until restart.
Solution for this was to change the get_cinfo() method to be instance based. Other class methods do not reference the settings values, and can remain class methods.
Fixes #198
In original code there are a few issues, preventing the Series Title Language setting from operating as expected.
There was also another issue, where after modifying settings in the UI: save_settings() is called and updates the instance's settings get_cinfo() is a class method and cannot read the updated saved settings. So settings update in the UI on the AniList provider but do not take effect until restart.
Solution for this was to change the get_cinfo() method to be instance based. Other class methods do not reference the settings values, and can remain class methods.