search

Mange / roadie-rails

Making HTML emails comfortable for the Rails rockstars
MIT License
363 stars 65 forks source link

Bump rails version dependency to <= 4.0.1 #1

Closed fenelon closed 10 years ago

fenelon commented 10 years ago

Just bumped the rails dependency. Why wouldn't we just put ~> 4.0,1 in there?

Mange commented 10 years ago

Hi,

I just started developing this gem and that Gemspec is just a placeholder still. The true requirement will most likely be a lot more liberal when it is finished. The older implementation of Roadie monkey patched private methods in Rails and needed very specific version requirements for that reason.

I will not accept this pull request since I'm this early in the development. Stay tuned.

Magnus

Den tisdagen den 12:e november 2013 skrev Ellin Tolstov:

Just bumped the rails dependency. Why wouldn't we just put ~> 4.0,1 in

there?

You can merge this Pull Request by running

git pull https://github.com/fenelon/roadie-rails master

Or view, comment on, or merge it at:

https://github.com/Mange/roadie-rails/pull/1 Commit Summary

  • Bump rails version dependency to <= 4.0.1

File Changes

  • M roadie-rails.gemspechttps://github.com/Mange/roadie-rails/pull/1/files#diff-0(2)

Patch Links: