search

Mange / roadie-rails

Making HTML emails comfortable for the Rails rockstars
MIT License
366 stars 65 forks source link

Adds initial Github Action #102

Closed davidwessman closed 2 years ago

davidwessman commented 2 years ago

2021-12-19: Tested out on my local branch and it now builds and runs tests for 2.6.9, 2.7.5 and 3.0.3 for all the Rails-versions available. Includes the change in #100 just to be able to run.

davidwessman commented 2 years ago

I am testing this out on: https://github.com/davidwessman/roadie-rails/pull/1

Not sure what is required to run the actions in this repo.

Mange commented 2 years ago

Very nice work here. Thank you for doing this. I was not looking forward to making this migration myself.

All the output looks sane in the PR on your fork. I'll merge this one!

Would you mind fixing all other references to "Travis" in the codebase? Both in README and in setup.sh.

davidwessman commented 2 years ago

Very nice work here. Thank you for doing this. I was not looking forward to making this migration myself.

All the output looks sane in the PR on your fork. I'll merge this one!

Would you mind fixing all other references to "Travis" in the codebase? Both in README and in setup.sh.

🙂 Glad to be able to help!

I updated all the Travis-references I could find, not 100% if I got the status badge right, we will have to iterate when we see it in action. I kept the word Travis in two of the comments related to the difference in setup on Travis vs Github Actions.

Mange commented 2 years ago

Excellent. Thank you! :heart: