search

Mange / roadie-rails

Making HTML emails comfortable for the Rails rockstars
MIT License
367 stars 66 forks source link

Adds support for propshaft #113

Closed jvillarejo closed 6 months ago

jvillarejo commented 6 months ago

I am migrating my webapp to use propshaft and dartsass and removing sprockets as the asset pipeline.

This PR introduce a new AssetPropshadtProvider to resolve the assets instead of the AssetPipelineProvider.

Sadly I couldn't make the specs work without running rails assets:precompile in the dummy rails app.

But it works perfectly using it as a gem. Currently my webapp is pointing to my github repo fork.

It fixes https://github.com/Mange/roadie-rails/issues/112

jvillarejo commented 6 months ago

Probably the only change I need

Done! Let me know if there is anything left I missed!

jvillarejo commented 6 months ago

I'm closing this PR. I'm fixing a couple of issues I found. Sorry for this! I will reopen it again later when I fix them.

jvillarejo commented 6 months ago

I reimplemented the solution and made another PR here: https://github.com/Mange/roadie-rails/pull/114