Adds support for propshaft (#2)

[jvillarejo]

I am migrating my webapp to use propshaft and dartsass and removing sprockets as the asset pipeline.

This PR introduce a new AssetPropshaftProvider to resolve the assets instead of the AssetPipelineProvider.

Researching propshaft more I ended replicating a similar idea implemented in the Propshaft::Server class.

We need to provide roadie with the compiled stylesheet, so it can:

• Reference the correct digested assets when using url(...) on the stylesheet.
• Compile the whole stylesheet if sass is being used.

Now the integration_spec works without requiring the assets to be compiled. It serves the compiled assets when running in development environment (which the dummy apps run)

I also added expectations for the body `background-color: green inlining.

It fixes https://github.com/Mange/roadie-rails/issues/112

[PikachuEXE]

CI failed https://github.com/Mange/roadie-rails/actions/runs/9022266978/job/24797354807?pr=114

Please fix when you can~

[jvillarejo]

There are some files that appear on the linter when running bundle exec standardrb that I didn't change This ones:

  lib/roadie/rails/mailer.rb:11:9: Style/ArgumentsForwarding: Use anonymous block arguments forwarding (`&`).
  lib/roadie/rails/mailer.rb:13:31: Style/ArgumentsForwarding: Use anonymous block arguments forwarding (`&`).
  lib/roadie/rails/options.rb:109:23: Performance/StringIdentifierArgument: Use `:"#{option}="` instead of `"#{option}="`.

¿Should I fix them too on this PR ?

[PikachuEXE]

Yes please

[jvillarejo]

There is a problem here. standardrb mark as linter errors this ones:

lib/roadie/rails/mailer.rb:11:9: Style/ArgumentsForwarding: Use anonymous block arguments forwarding (`&`).
lib/roadie/rails/mailer.rb:13:31: Style/ArgumentsForwarding: Use anonymous block arguments forwarding (`&`).
lib/roadie/rails/options.rb:109:23: Performance/StringIdentifierArgument: Use `:"#{option}="` instead of `"#{option}="`.

Fixing the one in lib/roadie/rails/options.rb shouldn't present any problem.

But the anonymous block arguments forwarding is a feature added in ruby 3.1 If I change that, the library won't be compatible with previous ruby versions.

I don't think that's part of the PR. but I don't know why the linter is now failing.

What should we do? I can ignore the errors with a comment.

[PikachuEXE]

Coz the lint job is run on ruby 3.2 Please ignore with config file https://github.com/standardrb/standard#ignoring-specific-rules-in-files-and-globs Better have one place to track all ignore rules (will be removed when support for earlier ruby versions dropped)

[jvillarejo]

Done @PikachuEXE

I added .standard.yml file to ignore those errors: https://github.com/Mange/roadie-rails/pull/114/commits/b6d8de1930dd439b33411fd7ef5b3009a6996c0b

[PikachuEXE]

CI failing now due to actual path shorten I have no idea if it's the default config changed or the setup in this project's testing causing it... https://github.com/Mange/roadie-rails/actions/runs/9326040234

[jvillarejo]

I will check it out.

[PikachuEXE]

@jvillarejo Any progress?

Edit 1: https://github.com/rails/propshaft/pull/173 ?

[jvillarejo]

Sorry @PikachuEXE I been having some rough weeks. I had this on my TODO list.
I will try to do fix it this week. Thanks for the link !

[jvillarejo]

Hey @PikachuEXE I made the PR that fixes the tests: https://github.com/Mange/roadie-rails/pull/115

Again, sorry for the delay. I had some very busy weeks.

[PikachuEXE]

It's simply test case no urgency at all! :)