search

Mange / roadie-rails

Making HTML emails comfortable for the Rails rockstars
MIT License
363 stars 65 forks source link

Update README.md #21

Closed agius closed 8 years ago

agius commented 9 years ago

Took forever to track down this issue with config.assets.digest, but it's a simple thing.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.12%) when pulling c2ed9b006e27c0149863eb090099dd89002f5ce3 on agius:patch-1 into ba67ea7afbb1ebb636aa4cd42feef9856c6cd5d2 on Mange:master.

Mange commented 9 years ago

Hmm, that is interesting. What happened in your case? It failed to find the assets? Would anything find the assets? It uses application-hashyhashy.css instead of application.css, but that file does not exist on disc and Rails does not serve it, right?

EDIT: If this is the case, I'm hesitant to even classify it under "Known issues" as this is not an issue of Roadie, but just a configuration error in the application. It might fit better under a "FAQ" like in the roadie project.

agius commented 9 years ago

Yes, that's correct - neither Sprockets nor the filesystem would return a valid result for /application-digest1234.css , so Roadie threw CssNotFound error. It would work if I precompiled assets, but I didn't want to have to do that for the test environment. If I set assets.compile = true and assets.digest = false, it fell back to the asset pipeline and worked correctly.

Mange commented 9 years ago

I'll accept this addition to the README if it's placed under a FAQ instead (see my comment above). It's not an issue with Roadie, but a potential issue with the app configuration (digest in test isn't really recommended anywhere). :-)

Mange commented 8 years ago

It's been a year. I'll close this for now.

If you still want to get this in, I'm more than happy to re-open this. :-)