search

Mange / roadie-rails

Making HTML emails comfortable for the Rails rockstars
MIT License
363 stars 65 forks source link

Previewing section of README not working #43

Closed davekaro closed 9 years ago

davekaro commented 9 years ago

I had to change the previewing section (https://github.com/Mange/roadie-rails#previewing) code to make html output work.

From

format.html { render html: email.html_part.decoded }

to

format.html { render html: email.html_part.decoded.html_safe }

This makes sense to me, but was surprised nobody else ran into it. Is it possible I've got something configured wrong? Does the decoded method return an html_safe string sometimes?

Mange commented 9 years ago

No that is most likely correct. I wrote the snippet from memory as I no longer worked with Rails when I typed it out.

Thanks for reporting it. I'll update the README.

ons 24 jun 2015 18:52 Dave Kroondyk notifications@github.com skrev:

I had to change the previewing section ( https://github.com/Mange/roadie-rails#previewing) code to make html output work.

From

format.html { render html: email.html_part.decoded }

to

format.html { render html: email.html_part.decoded.html_safe }

This makes sense to me, but was surprised nobody else ran into it. Is it possible I've got something configured wrong? Does the decoded method return an html_safe string sometimes?

— Reply to this email directly or view it on GitHub https://github.com/Mange/roadie-rails/issues/43.