search

Mange / roadie-rails

Making HTML emails comfortable for the Rails rockstars
MIT License
367 stars 66 forks source link

Forced delivery #47

Closed monkbroc closed 8 years ago

monkbroc commented 8 years ago

When I tried using roadie-rails in combination with a bang version of the Rails mailer deliver methods to skip raising exceptions the email styles were not inlined.

# Did not inline styles like deliver_now
UserMailer.welcome(user: user).deliver_now!

I propose to intercept the deliver! message on Mail instances as well as the deliver message to trigger the automatic inlining of styles.

I restructured the integration test a bit to avoid another copy of the email validation code.

Mange commented 8 years ago

This looks really nice. Thank you!

monkbroc commented 8 years ago

Great. Thanks for merging @Mange!

Mange commented 8 years ago

I just released roadie version 3.1.0 and roadie-rails 1.1.0 containing these fixes.

monkbroc commented 8 years ago

Wow. You don't mess around Magnus!

Thanks for your dedication. It's really appreciated you know.