Mange / roadie-rails

Making HTML emails comfortable for the Rails rockstars
MIT License
367 stars 66 forks source link

Unable to load mail.css with rails 4.2.6, roadie-rails 1.1.1 #56

Closed Hugo-Hache closed 8 years ago

Hugo-Hache commented 8 years ago

When setting Rails.application.assets.compile = false (prod env), Roadie has only one asset provider: #<Roadie::FilesystemProvider app/public>

In #46, AssetPipelineProvider creation is done in a block given to Rails.application.config.assets.configure, normally invoked with environment when the environment is initialized (cf. sprocket-rails README).

However, this block is never called, and then without AssetPipelineProvider Roadie is unabled to find my precompiled mail.css suffixed with the digest.

Did I misconfigure Rails or is this a bug ? Thanks !

Mange commented 8 years ago

I'm not sure I understand completely, so please bear with me where I try to understand.

You're not compiling on production. Do you precompile or do you work with static assets that need no compilation?

When you include the asset in your email, do you use the built-in asset helpers (stylesheet_link_tag)? Does it output the asset as /assets/stylesheets/mail-<sha>.css or as /assets/stylesheets/mail.css?

Hugo-Hache commented 8 years ago

Issue appeared only in production where I use asset precompilation. Thanks to your precise questions I spotted that I was mistakenly not using stylesheet_link_tag, but a direct link. Sorry bothering you, and thanks for the blazing fast and effective answer @Mange !

Mange commented 8 years ago

I'm glad it worked out for you! ☺️

Den ons 16 mars 2016 15:25Hugo Hache notifications@github.com skrev:

Closed #56 https://github.com/Mange/roadie-rails/issues/56.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/Mange/roadie-rails/issues/56#event-591907330