search

Mange / roadie-rails

Making HTML emails comfortable for the Rails rockstars
MIT License
363 stars 65 forks source link

Fix Upgrading.md markup #7

Closed tricknotes closed 10 years ago

tricknotes commented 10 years ago

I fixed Upgrading.md's markup:

2014-06-28 23 49 41 :arrow_down: 2014-06-28 23 49 51

By the way, why :css option has gone? I liked it. Are there something problem with it? Ah, this question is just a interest :-)

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 261752996963c832928716c41308650e7e37cf3d on tricknotes:fix-markup into 160bb8603661b743d5d8f15b063237f47a755c14 on Mange:master.

Mange commented 10 years ago

Thanks!

By the way, why :css option has gone? I liked it. Are there something problem with it?

Well, it meant we needed to interface with ActionMailer by monkey patching and extending rather than by using public APIs. Automatic still uses extensions, but it does it in a place that should be a lot more stable. There was also the huge problem with precompiled assets that came from this option. A controller does not know about the assets, only the view does that. Accessing the view code and trying to integrate with it was non-trivial.

Basically, it should increase compatibility and reduce bugs over time, while still being simpler. We had to support <link> elements, but we didn't have to support the :css option, if you see what I mean. :-)

tricknotes commented 10 years ago

Thanks for your commentary! It was found well :-)