Closed glebm closed 7 years ago
Merging #70 into master will decrease coverage by
59.81%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #70 +/- ##
===========================================
- Coverage 95.99% 36.18% -59.82%
===========================================
Files 21 2189 +2168
Lines 599 102571 +101972
===========================================
+ Hits 575 37113 +36538
- Misses 24 65458 +65434
Impacted Files | Coverage Δ | |
---|---|---|
spec/support/rails_app.rb | 93.87% <100%> (+2.57%) |
:arrow_up: |
...ems/nokogiri-1.7.1-java/lib/nokogiri/xml/schema.rb | 0% <0%> (ø) |
|
...0.5/lib/concurrent/atomic/ruby_thread_local_var.rb | 31.34% <0%> (ø) |
|
...ms/mail-2.6.5/lib/mail/fields/resent_from_field.rb | 64.28% <0%> (ø) |
|
.../gems/mail-2.6.5/lib/mail/fields/reply_to_field.rb | 0% <0%> (ø) |
|
...1.0/lib/active_support/core_ext/object/deep_dup.rb | 43.75% <0%> (ø) |
|
...s/nokogiri-1.7.1/lib/nokogiri/xml/xpath_context.rb | 71.42% <0%> (ø) |
|
...dle/ruby/2.4.0/gems/nokogiri-1.7.1/lib/nokogiri.rb | 52.17% <0%> (ø) |
|
...s/mail-2.6.5/lib/mail/fields/common/common_date.rb | 62.5% <0%> (ø) |
|
... and 2163 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9e3cb2e...a18e404. Read the comment docs.
@Mange I believe this addresses all of the critical/urgent issues. Let's merge this in and release a new version?
Thank you very much! All of this makes sense, and the commits have good motivations behind them. :heart:
I just released version 1.2.0 including this PR. Thank you again!
MRI rubies < 2.2 have not been maintained for over a year and no longer receive security fixes! Nobody should be supporting these versions anymore. https://www.ruby-lang.org/en/news/2017/04/01/support-of-ruby-2-1-has-ended/
Updates .travis.yml to only test on latest PATCH versions for 2.2, 2.3, and 2.4. Relaxes
jruby-9.1.5.0
tojruby-9
, and changesrbx
torbx-3
(asrbx
alone does not work at all on travis).With this, #69 and #65 can be closed.