search

Mange / roadie-rails

Making HTML emails comfortable for the Rails rockstars
MIT License
367 stars 66 forks source link

Relax version constraint to work with Rails 5.1 #71

Closed dhh closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #71 into master will increase coverage by 0.97%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   95.99%   96.96%   +0.97%     
==========================================
  Files          21       21              
  Lines         599      593       -6     
==========================================
  Hits          575      575              
+ Misses         24       18       -6
Impacted Files Coverage Δ
lib/roadie/rails/options.rb 100% <0%> (+2.81%) :arrow_up:
spec/lib/roadie/rails/mailer_spec.rb 100% <0%> (+2.85%) :arrow_up:
spec/lib/roadie/rails/automatic_spec.rb 100% <0%> (+3.12%) :arrow_up:
spec/support/rails_app.rb 95.45% <0%> (+4.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e3cb2e...96d4e8a. Read the comment docs.

Mange commented 7 years ago

Thank you for all your time. I felt that #70 was an even better fix, so I've merged that one instead.

I'll release a new version shortly.

Mange commented 7 years ago

I just released version 1.2.0 including Rails 5.1 support.

dhh commented 7 years ago

Magnus, this will fix the immediate problem, but also unfortunately ensure we face the same problem with 5.2. I don't think roadie-rails is served by such a pessimistic dependency on Rails. 5.1 has been out for a while and in that time people simply couldn't use this gem, even though there were no actual incompatibilities. We are moving all the direct Rails dependencies off pessimistic locks against future versions and will publish a plea for the community to do the same on a grand scale. Would be great to have roadie-rails be part of that push. Thanks!

On May 10, 2017, at 08:30, Magnus Bergmark notifications@github.com wrote:

I just released version 1.2.0 including Rails 5.1 support.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.