codecov-io commented 7 years ago

Codecov Report

Merging #72 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   36.18%   36.18%           
=======================================
  Files        2189     2189           
  Lines      102638   102638           
=======================================
  Hits        37137    37137           
  Misses      65501    65501

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b89eddc...31b70cb. Read the comment docs.

Mange commented 7 years ago

Thank you!

iNecas commented 7 years ago

Just out of curiosity? What was the reason for this change? We there some incompatibilities for 2.1 introduced?

Mange commented 7 years ago

No, but I want to be able to.

Supporting those versions would be costly over time since they are deprecated and receive no security updates anymore. It's the same reason as I don't support 1.8 or 2.0.

The 1.1 branch is still supported for a bit more, so if there's any bug fixes in 1.2 that you need we can backport them on request. ☺️

Den fre 12 maj 2017 14:26Ivan Necas notifications@github.com skrev:

Just out of curiosity? What was the reason for this change? We there some incompatibilities for 2.1 introduced?

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/Mange/roadie-rails/pull/72#issuecomment-301062975, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAGP4TvKOnXrtmkNOVkpqtHCylaCGDOks5r5E_ugaJpZM4NWi_B .

Mange / roadie-rails

specify required_ruby_version >= 2.2 in gemspec #72

Codecov Report