Mange / roadie-rails

Making HTML emails comfortable for the Rails rockstars

MIT License

366 stars 65 forks source link

Test on Ruby 2.5 #82

Closed tricknotes closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #82 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          16       16           
  Lines         496      496           
=======================================
  Hits          488      488           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cddb4f7...7f64ee3. Read the comment docs.

Mange commented 6 years ago

Weird how so many new files were placed under bundle/ruby/2.5.0 causing coverage report to go crazy.

Is this something you can see happening locally for you too? Is there files placed under bundle/ruby/2.5.0?

Mange commented 6 years ago

Looks like the bundles are placed under bundle intead of .bundle from the looks on codecov. Very weird considering that the setup script asks to use .bundle... 😕

tricknotes commented 6 years ago

Sorry for my late response :< Unexpected coverage was resolved by https://github.com/Mange/roadie-rails/pull/85 . And I rebased my commit and all tests are passed on Travis CI.

@Mange Could you review this PR again ? 🙇

Mange commented 6 years ago

Can you add it to the README and Changelog too? Then I could merge right away. 😀

You can base the Changelog entry from the last one for 2.4.

tricknotes commented 6 years ago

Sure! I updated my commit. Is is OK?