search

Mange / roadie-rails

Making HTML emails comfortable for the Rails rockstars
MIT License
363 stars 65 forks source link

Relax Rails dependency to < 6.1 #88

Closed glebm closed 5 years ago

glebm commented 5 years ago

Rails 6.0 is about to be released

codecov-io commented 5 years ago

Codecov Report

Merging #88 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files          18       18           
  Lines         566      566           
=======================================
  Hits          564      564           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1eddf1c...0b07387. Read the comment docs.

Mange commented 5 years ago

I'd like you to embed a Rails 6 application for the integration tests.

glebm commented 5 years ago

@Mange Done!

glebm commented 5 years ago

Done!

Mange commented 5 years ago

Excellent! Thank you very very much! :heart:

Mange commented 5 years ago

Version 2.1.0 was just released containing this.

glebm commented 5 years ago

Thanks!

glebm commented 5 years ago

I can't see it on RubyGems: https://rubygems.org/gems/roadie-rails

Mange commented 5 years ago

D'oh! Forgot to push the package. Will push it tomorrow when I get home.

You can use the tag on GitHub in the meantime.

Sorry about that!

Den lör 13 apr. 2019 13:20Gleb Mazovetskiy notifications@github.com skrev:

I can't see it on RubyGems: https://rubygems.org/gems/roadie-rails

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Mange/roadie-rails/pull/88#issuecomment-482800538, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAGP9RPpc5AD7WiipB5s-4uDiCla7nuks5vgb2KgaJpZM4cUWAG .

Mange commented 5 years ago

It is now pushed! Thank you for letting me know.