Mange / roadie-rails

Making HTML emails comfortable for the Rails rockstars

MIT License

367 stars 66 forks source link

Relax roadie dependency to allow v4.x #89

Closed adzap closed 4 years ago

adzap commented 4 years ago

Allow usage with v4.x of roadie gem

Mange commented 4 years ago

I was pretty sure >= should allow 4.x here. Are you sure it prevents that version?

adzap commented 4 years ago

It was not a ‘>=‘ but a ‘~>’. The ‘~> 3.1’ will only allow >= 3.1.0 to 3.x gem variants. On 7 Jan 2020, 2:24 AM +1100, Magnus Bergmark notifications@github.com, wrote:

I was pretty sure >= should allow 4.x here. Are you sure it prevents that version? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

Mange commented 4 years ago

Well I be damned. Thank you!

I wonder about those CI errors. I suppose something needs to be changed in the embedded Rails apps nowadays. I'll see what I can do about that.

adzap commented 4 years ago

Thank you!

Those errors looked too hairy for me to just wander into at the moment. On 7 Jan 2020, 7:12 PM +1100, Magnus Bergmark notifications@github.com, wrote:

Well I be damned. Thank you! I wonder about those CI errors. I suppose something needs to be changed in the embedded Rails apps nowadays. I'll see what I can do about that. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

Mange commented 4 years ago

Please rebase on top of master to get a working base to work on. You might also want to add an entry to the Changelog.

codecov-io commented 4 years ago

Codecov Report

Merging #89 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files          18       18           
  Lines         566      566           
=======================================
  Hits          564      564           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f9537ce...5289d14. Read the comment docs.

adzap commented 4 years ago

And thank you! On 8 Jan 2020, 2:44 AM +1100, Magnus Bergmark notifications@github.com, wrote:

Merged #89 into master. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

Mange commented 4 years ago

Version 2.1.1 was just released with this fix in it.

adzap commented 4 years ago

Great thank you! On 10 Jan 2020, 6:28 AM +1100, Magnus Bergmark notifications@github.com, wrote:

Version 2.1.1 was just released with this fix in it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.