Mange / roadie-rails

Making HTML emails comfortable for the Rails rockstars
MIT License
367 stars 66 forks source link

Rails 7.0 support - drop support for Ruby 2.5 #97

Closed Mange closed 2 years ago

Mange commented 2 years ago

Main body of work is authored by @SeanLF in #96. This too will close #94.

Dropping support for Ruby 2.5 since it has been EoL'ed and is no longer supported by Ruby core.

This version of @SeanLF's changes will no longer try to run the Rails 7.0 integration tests on older versions of Ruby since that version of Rails requires Ruby 2.7.0 or later.

Mange commented 2 years ago

I'll make some other changes I want to this repo, then I will release a new version within a day or so. I would welcome anyone needing Rails 7 support to test the master branch and letting me know if it works or not in the meantime, especially if I can't keep to this loose deadline. :see_no_evil:

adrijere commented 2 years ago

Hi @Mange, Thanks for your work! Do you know if a new version will be released soon?

We (@SeanLF and I) are using the master branch with Rails 7 and we didn't catch any errors for now :).

Mange commented 2 years ago

Yes, absolutely. I just forgot about it again.

I'd want #99 to get in too, though.