Mange / rofi-emoji

Emoji selector plugin for Rofi
MIT License
551 stars 26 forks source link

Feature/Improvement request: Favorites / most used emojis as default #42

Open DiggsAsura opened 2 years ago

DiggsAsura commented 2 years ago

Hi,

I'm still just an aspiring programmer myself, so can't really put up a pull request or anything.. But Here's a thing I would love to see in this plugin.

Either or:

  1. Sort after usage (favorites) and/or
  2. Make lists of favs, which then will be default

I just started using this, so this is coming from very fresh (and very happy!) eyes, after wathing the LInuxCast episode just now.

Mange commented 2 years ago

I'm glad to hear it!

Sadly, since this is a plugin to Rofi instead of a script that wraps Rofi, we're limited to the very small API that Rofi exposes.

For example:

What we could do is build our own parallell config file to be placed under .config/rofi/rofi-emoji and use that for certain settings. We could also respond to environment variables instead of CLI arguments in order to toggle some things.

It's all pretty hacky really, and will never be super comfortable to use. I think I would recommend anyone that wants features like this to do so by wrapping Rofi in a script, where this plugin could act as a data source of some sort. Then the only thing that is really required here is probably to make it easier to swap in other Emoji data files.

So, to summarize:

I'll open up an issue detailing what I think this plugin should add to make this easier for people like you. :-)

Mange commented 2 years ago

See #43

Mange commented 2 years ago

Thanks to you I had another look through Rofi's header files and found out a lot of features in their Plugin API that I wasn't aware of.

This was the basis for my rework into version 3: #44.

I suspect with the foundation inside there that we could add real "favorites" functionality in the plugin proper, but it's going to be a bit further along.

DiggsAsura commented 2 years ago

Amazing!

Mvh Kenneth Bæver Bjerke +47 966 21 811

On Fri, Jul 1, 2022 at 1:31 AM Magnus Bergmark @.***> wrote:

Thanks to you I had another look through Rofi's header files and found out a lot of features in their Plugin API that I wasn't aware of.

This was the basis for my rework into version 3: #44 https://github.com/Mange/rofi-emoji/pull/44.

I suspect with the foundation inside there that we could add real "favorites" functionality in the plugin proper, but it's going to be a bit further along.

— Reply to this email directly, view it on GitHub https://github.com/Mange/rofi-emoji/issues/42#issuecomment-1171769948, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7OB5ZEZ6KYGGY2WNZ5TCLVRYU5HANCNFSM5YJVNUYA . You are receiving this because you authored the thread.Message ID: @.***>