search

Mange / rofi-emoji

Emoji selector plugin for Rofi
MIT License
555 stars 26 forks source link

Can't compile from source #45

Closed motorto closed 2 years ago

motorto commented 2 years ago 
$ autoreconf -fi
libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
configure.ac:56: error: possibly undefined macro: PKG_HAVE_WITH_MODULES
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: /usr/bin/autoconf failed with exit status: 1

Could you help me debug what I am missing ? I currently have installed (I am running void trying to install the 3.0):

Am I missing any package ?

Mange commented 2 years ago

I suspect this could happen with an older version of autoconf or automake, but it could also be that some other package needs to be installed to add that macro.

Which versions do you have installed of the software listed in OP?

motorto commented 2 years ago

According to the package manager:

Mange commented 2 years ago

So the macro on my Arch machine is defined in pkgconf, which is on version 1.8.0. https://github.com/pkgconf/pkgconf

It's not clear to me if that's the same package as pkg-config is on your machine, but the version you have has never been released for pkgconf before so I think they are different software packages. On Arch pkg-config is provided by this package, however.

Which distribution are you on?

motorto commented 2 years ago

I am using Void Linux.

Okay, found the issue on void linux pkg-config is http://pkgconfig.freedesktop.org/ and on arch is http://pkgconf.org/. So on voidlinux it is pkgconf the package to install instead of package-config.

The list of packages on void:

On 22/07/24 11:34AM, Magnus Bergmark wrote:

So the macro on my Arch machine is defined in pkgconf, which is on version 1.8.0. https://github.com/pkgconf/pkgconf

It's not clear to me if that's the same package as pkg-config is on your machine, but the version you have has never been released for pkgconf before so I think they are different software packages. On Arch pkg-config is provided by this package, however.

Which distribution are you on?

-- Reply to this email directly or view it on GitHub: https://github.com/Mange/rofi-emoji/issues/45#issuecomment-1193371280 You are receiving this because you authored the thread.

Message ID: @.***>

Mange commented 2 years ago

Hmm, Void is also on 1.8.0 for pkgconf.

I'll see if I can vendor that macro into the repo so the dependency isn't needed.

[EDIT after your EDIT]: I see. So Arch didn't separate pkg-config binary from Freedesktop from the pkg-config binary from the pkgconf project and only use the latter. Whereas you might be using both in a mix on Void.

Mange commented 2 years ago

Would you mind testing on the latest master?

motorto commented 2 years ago

https://github.com/void-linux/void-packages/pull/38251

Would you mind testing on the latest master?

Removing the pkgconf package ? Sure.

Mange commented 2 years ago

I think latest master might work with either pkg-config or pkgconf :-)

If so I could release a patch release.

motorto commented 2 years ago

It does compile fine with only pkg-config from master (void linux)

Mange commented 2 years ago

Thanks. I'll release this shortly

Mange commented 2 years ago

Version 3.0.1 was just released with this fix included.

motorto commented 2 years ago

Version 3.0.1 released on void repos. Thanks for your help and the quick fix !