Mango-information-systems / twitto_be

twitto_be is a real-time tweets analytics dashboard
https://twitto.be
Other
12 stars 2 forks source link

Support for different countries #116

Closed PanosSynetos closed 7 years ago

PanosSynetos commented 7 years ago

All country details should be done in a params file, making it easy to run separate instances of twitto per country

PanosSynetos commented 7 years ago

@mef could you please have a look? Checkout branch issue-116-country-params-wip I believe I've moved all country related settings to params.json

Do not forget to copy from params-sample.json

What do you think?

PanosSynetos commented 7 years ago

We might need to setup different persist files for each country, so that we don't accidentally mess up.

PanosSynetos commented 7 years ago

Added some more parameters in json file and a sample-json for Greece

mef commented 7 years ago

Heads-up Panos, I've made a small change in params.json structure (cf previous commit) - branch 3.0.0-wip

PanosSynetos commented 7 years ago

@mef fixed 502 texts and merged with 3.0.0 Please check. Next task here is to camelcase all the params

EDIT: Merged in 3.0.0.-wip

PanosSynetos commented 7 years ago

Greece is working fine. I've also updated the json files Moving it to please test

image

mef commented 7 years ago

Heads-up @11digitlabs

All the geo-related settings have been moved in a separate file outside of params.json.

This is because this data is require-d inside client-side map.js view, and it was causing the twitter app keys to be leaked to the client.

Please have a look at the commit d1be7c3, you'll need to adapt files accordingly.