search

Mango / slideout

A touch slideout navigation menu for your mobile web apps.
https://slideout.js.org
MIT License
7.94k stars 1.15k forks source link

Suggestion: static panel, sliding menu. #140

Open mauron85 opened 8 years ago

mauron85 commented 8 years ago

Current implementation is that menu is static and panel is moved to side to reveal menu by translate3d.

However, most menu implementations (tinder, facebook) actually do it in reverse manner, so panel is static and menu is revealing.

Can this be implemented?

wesleyfsmith commented 8 years ago

Yes, this is also how I would prefer to use this library as well. Would be good to know if anyone knows how to get it functioning in this manner.

AaronLayton commented 8 years ago

@pazguille I too would like to pull out the Menu as a Panel - Would this just be as easy as swapping around what we class as the Menu and the Panel?

pazguille commented 8 years ago

+1 It should be configurable to support both cases well.

pazguille commented 8 years ago

@AaronLayton It is not so simple. I'll work in this feature.

AaronLayton commented 8 years ago

I got it working the other night how I figured it should work. I will see if I can post you a pull request ;-)

On 25 December 2015 at 14:32, Guille Paz notifications@github.com wrote:

@AaronLayton https://github.com/AaronLayton It is not so simple. I'll work in this feature.

— Reply to this email directly or view it on GitHub https://github.com/Mango/slideout/issues/140#issuecomment-167242385.

nolandg commented 8 years ago

Did anyone get this working? I don't seem to see the pull request...

stevenmunro commented 8 years ago

I began working on this until I saw this issue. I managed to swap out instances of panel with menu in the JS file, however I'm having problems with the translate properties between transitions. My underpants are really twisted.

Does anyone have any code they want to share? @pazguille @AaronLayton

salazarr-js commented 8 years ago

+1

nstanard commented 8 years ago

Would also like to see this happen. +1

groomain commented 8 years ago

+1 Any advance for this feature ?

aguilera51284 commented 8 years ago

+1

AaronLayton commented 8 years ago

Sorry it took a while everyone but here is the modifications I made to get this working. Hopefully my PR can be used as a starting point to get a better implementation, but if nothing comes of this then you can use the version here https://github.com/AaronLayton/slideout

AaronLayton commented 8 years ago

Any news on this PR?

hoIIer commented 7 years ago

+1 any movement?

pazguille commented 7 years ago

Hi @erichonkanen!

I have been working on this feature and other improvements here:

Branch: https://github.com/mango/slideout/tree/new-features

Demo: https://slideout.js.org/new-features

Soon it going to be merged into master and I'll publish a new version 2.0.0

AaronLayton commented 7 years ago

@pazguille great work! I like how your not changing the display of the slideout-menu anymore - that was always a perf issue for me. Having to draw the menu just before we slide it out was causing some hickups on slower devices.

Another perf issue for me is adding the slideout-open class to the <html> tag. Any chance this could be changed to a visible class just being added to a target element? Either add to slideout-dimmer as default or something else we can specify?

Sidenote: you do use the class to get rid of the scrollbar on body, so probably still need the class on the HTML tag

pazguille commented 7 years ago

@AaronLayton Yes, I think there are no problem to do that. I will work on your comments. Thanks!

JacobDB commented 6 years ago

@pazguille Any progress on integrating this in to master? Would love to use the overlay variant!