search

MangoAutomation / ma-core-public

Mango Automation Core public code
Other
79 stars 50 forks source link

RAD-3446 Fix MailingListServiceTest when DST switchover #1835

Closed MertCingoz closed 1 year ago

terrypacker commented 1 year ago

@MertCingoz some description of what you did in this PR would be good. It looks like there was a bug in the test and not the code?

MertCingoz commented 1 year ago

@MertCingoz some description of what you did in this PR would be good. It looks like there was a bug in the test and not the code?

This test predicts that intervalIds will increase by 1 at a time, but it is not valid for daylight saving times. I don't see other problems in code. IntervalId and WeeklySchedule looks not related with timezone at all. InactiveIntervalConversionTest

terrypacker commented 1 year ago

Thanks. For reference here's a good PR with a description and info that helps the reviewer get their job done faster:

https://github.com/MangoAutomation/ma-modules-private/pull/494