MangoAutomation / ma-core-public

Mango Automation Core public code
Other
79 stars 50 forks source link

Core - XIDs no character restrictions #918

Open Puckfist opened 8 years ago

Puckfist commented 8 years ago

Lots of meaningful characters are permitted in XIDs! Some functions rely on XIDs not having those characters - for instance the GET /v1/point-values/{xids}/multiple-points-single-array uses comma separation for the XIDs. I noticed I downloaded data from the wrong point (DP_1,000 downloaded data for DP_1)!

I imagine there are a few other characters to break things with. % seems like it breaks some of the old pages (get point by XID on old data point details). It also seems to mess with the RQL

Perhaps we should validate? Perhaps these are undocumented features for how to deny using certain endpoints?

Puckfist commented 6 years ago

There are other things that may need character restrictions, such as usernames. I noticed I had some problem with a / in a username.