MangoCubes / cryptomator-web

Access Cryptomator vault over WebDAV in browser without installing any programs
MIT License
5 stars 1 forks source link

Add OneDrive #3

Closed burningscript closed 1 year ago

burningscript commented 1 year ago

Hello, is it possible to add OneDrive?

MangoCubes commented 1 year ago

I'll try, but I cannot guarantee it, since I have never used OneDrive before. However, there is a library that seems to do what I need (onedrive-api), and hopefully it can be abstracted.

burningscript commented 1 year ago

That would be really cool! Sadly I dont know Typescript ans therefore I am not able to do this by myself

Von meinem iPhone gesendet

Am 09.05.2023 um 18:09 schrieb MangoCubes @.***>:



I'll try, but I cannot guarantee it, since I have never used OneDrive before. However, there is a library that seems to do what I need (onedrive-api), and hopefully it can be abstracted.

— Reply to this email directly, view it on GitHubhttps://github.com/MangoCubes/cryptomator-web/issues/3#issuecomment-1540472817, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC5IUY7C5YLUYSNYMU6FY6LXFJT3DANCNFSM6AAAAAAX3LYGH4. You are receiving this because you authored the thread.Message ID: @.***>

MangoCubes commented 1 year ago

Okay, so after a bit of trial and error, I finally got how the hell Microsoft login works. Additionally, the library I found seems to not work with browser for some reason (not to mention the lack of typing), so I have to implement all that myself. Sorry, it might take more than expected. But I have successfully managed to get getting item list working, and I only need to add OneDrive class for this to work.

MangoCubes commented 1 year ago

I've managed to implement OneDrive client, did some basic testing and it seems to be working. Can you test it here?

https://mangocubes.github.io/cryptomator-web/

To login, press the "Use OneDrive Instead", and log in to your Microsoft account. It works only with personal accounts for now. Do let me know of the bugs, though I haven't done extensive debugging yet. That, and whether you managed to log in at once. OneDrive login initially took me a couple of attempts to log in, but I cannot reproduce it anymore, and I have no idea whether it's fixed or it just doesn't happen with my account anymore or something like that.