search

MangoFVTT / fvtt-ready-set-roll-5e

A module for faster, easier, and more dynamic rolling in the D&D 5th Edition system for Foundry VTT.
GNU General Public License v3.0
39 stars 18 forks source link

[BUG] Module incompatibility - Libwrapper warn with "Lock & Key" #425

Closed Gensokian closed 2 months ago

Gensokian commented 6 months ago

Description

Whenever a player logs into the VTT they get the error, that LocknKey modify the same functionality.

Console warn:

libWrapper: module Ready Set Roll for D&D5e and module Lock & Key modify the same FoundryVTT functionality and are more likely to conflict.
Detected non-libWrapper wrapping of 'ItemSheet.prototype._onChangeTab' by module ready-set-roll-5e. This will potentially lead to conflicts.

Versions

Other Modules

Lock & Key Libwrapper

L&K Issue: https://github.com/Saibot393/LocknKey/issues/86

Saibot393 commented 6 months ago

I looked into it and the problem seems to be, that Ready set Roll uses manual monkey patching (in hooks.js), replacing the ItemSheet.prototype._onChangeTab with the libwrapper equivalent if the module is active should solve it (if possible with as "WRAPPER")

MangoFVTT commented 2 months ago

Issue should be resolved and will be in the next release