Dice So Nice 5.0+ does not roll for attacks while RSR5e is enabled.

MangoFVTT / fvtt-ready-set-roll-5e

A module for faster, easier, and more dynamic rolling in the D&D 5th Edition system for Foundry VTT.

GNU General Public License v3.0

42 stars 21 forks source link

Dice So Nice 5.0+ does not roll for attacks while RSR5e is enabled. #472

Closed friction1 closed 1 month ago

friction1 commented 3 months ago

Dice So Nice 4.X.X seems to work appropriately with the latest RSR for 5e, but they just released an update (now 5.0.3) and now the dice do not roll when you click on attacks for PCs or NPCs.

Steps to Reproduce

Enable DsN 5.0.3 and RSR5e 3.1.4
Click on an attack for any NPC or PC
DsN dice do not appear as expected

Versions

Module: 3.1.4
dnd5e: 3.3.1
Foundry: 12.330

Other Modules Dice So Nice v 5.0.3

Oxy949 commented 3 months ago

Confirmed. I have the same issue.

MissZerglot commented 3 months ago

Can confirm that this is also the case in V11 of foundry.

nschoenwald commented 3 months ago

Damage dice show up if you have manual rolling enabled, but the automatically rolled attack does not show 3d dice.

MangoFVTT commented 3 months ago

Just noting that I am looking into this, but the DSN update has some fairly major changes to the API functions that will take time to fix with RSR

MangoFVTT commented 3 months ago

After investigating, the issue appears to be caused by a bug in DSN. I've reported it to the author here: https://gitlab.com/riccisi/foundryvtt-dice-so-nice/-/issues/435

Moonshaft commented 3 months ago

Hm. Looks like this is still happening when using Dice So Nice v5.0.5 as well.

nschoenwald commented 3 months ago

No fix has been published for this in Dice So Nice yet. The last version (5.0.5) was published over three weeks ago. So we will have to wait for the next release for this to be fixed. I'm still using the last v4 release in the meantime.

MangoFVTT commented 1 month ago

As of DSN 5.1.3 and RSR 3.3.0, this no longer seems to be an issue. DSN is rolling largely as expected for me. I would advise creating new tickets for any DSN related issues that come up moving forward.