search

MangoFVTT / fvtt-ready-set-roll-5e

A module for faster, easier, and more dynamic rolling in the D&D 5th Edition system for Foundry VTT.
GNU General Public License v3.0
42 stars 20 forks source link

[BUG] Third dice during simultaneous rolling (advantage or disadvantage) #477

Closed DragonHale closed 3 months ago

DragonHale commented 3 months ago

Description When rolling for advantage or disadvantage, there is a third roll of the dice that shouldn't be there (none of us have elven accuracy).

Steps to Reproduce

  1. Roll for advantage or disadvantage with simultaneous rolls (shift or ctrl commands to roll, or vanilla adv/dis roll)
  2. Watch three dice being rolled for the attack (easier to watch if you have manual rolls enabled, as you get three requests for the roll). If Dice so nice happens to work, you will see three dice on the screen instead of two. The third die is a little delayed.
  3. The third roll doesn't seem to be taken into account for the attack, but it disrupts the session a lot during manual rolling.

Versions

Other Modules I'm also using dice so nice 5.0.5 and the 3D dice rarely display. I've seen other issues opened for this bug so not reporting it separately.

MangoFVTT commented 3 months ago

I haven't been able to reproduce this error on my end. Enabling/disabling elven accuracy seems to be working exactly as intended and only printing 3 rolls when rolling advantage on an appropriate check. Even enabling Always Roll Multiple Dice has not printed 3 dice at wrong moments. This also makes sense because RSR is not the one that is deciding whether Elven Accuracy should be applied to the roll any longer, it is handled by the base system, which does not have the issue afaik.

image

Can you ensure 100% that there is no effect or anything similar that is giving Elven Accuracy? Or that you are not using ANY roller module aside from RSR?

DragonHale commented 3 months ago

I just tested in a test world with zero modules with a character straight from the SRD (dragonborn cleric. No elven accuracy and I did check that it didn't have it just in case).

The problem persists. However, I noticed that the problem is present exclusively when I hit alt to simulate a vanilla roll (which my rogue uses a lot because he adds sneak attack manually constantly through the situational bonuses). I hit alt, then hit attack in the chat card and go for advantage or disadvantage (doesn't matter which). The manual rolling feature asks me for two d20 rolls grouped together, then after that prompt disappears, I get second prompt for another d20. This last roll will get ignored by foundry and then the chat card will re-render and show me the first two rolls again so that I can roll for damage.

I also tested without ready set roll enabled to see if it was a core bug, but it isn't. I only get the issue with ready set roll. If you have dice so nice, you can see three dice being rolled even if you aren't using foundry's manual rolling feature. It doesn't seem to affect anything for gameplay, since the third roll seems to be completely ignored, but it does slow things down if we are using manual rolling, since the players are needlessly getting extra prompts.

I tried recording the screen with the bug in action but the file is too big :( Maybe you can see it through this link (I uploaded the video to discord) https://cdn.discordapp.com/attachments/948431274807267328/1272734461968122010/Desktop_2024.08.12_-_20.44.35.05.mp4?ex=66bc0dd5&is=66babc55&hm=e6579c1ca6603e1090ef2ee61e6d78f90cdc57961d8d69c0d611676fef0794de&

MangoFVTT commented 3 months ago

Ahh think the problem is with the Manual Rolls input, because that is the only thing you are doing differently than me. I suspect RSR's vanilla message processing doesn't interact very well with the manual roll result input prompts because it's not something that I've ever tested since I don't use it. If you disable manual rolls it will probably work as expected until I figure out a fix

MangoFVTT commented 3 months ago

Issue should be fixed and will be in the next release.

NOTE: if you are using Always Roll Multiple Dice along with Manual Rolls, you'll still get 2 prompts to fill in (though the AMOUNT of dice now will be correct). This is unavoidable because dnd5e doesn't really support the notion of rolling multiple dice always. However, the prompts now should have the appropriate number of fields to fill in instead of having extras.

DragonHale commented 3 months ago

Yes! The issue is now gone. Thank you very much for both the quick replies and also the quick fixing :)