MangoFVTT / fvtt-ready-set-roll-5e

A module for faster, easier, and more dynamic rolling in the D&D 5th Edition system for Foundry VTT.
GNU General Public License v3.0
40 stars 20 forks source link

[FEATURE] Other Activities for Versatile, Light and Thrown Weapons via Script or Macro #507

Closed maxobremer closed 1 hour ago

maxobremer commented 2 hours ago

Is your feature request related to a problem? Please describe. With the way the dnd5e system handles versatile weapons and the like, using a longsword two handed has become a bit of a pain

Describe the solution you'd like Maybe RSR could come with a script that when an item gains/has the versatile, light or thrown property they gain extra activities that are copies of the normal attack activities but with some adjustments to the damage formula to create separate activities for Two-handed, Offhand and Thrown attacks.

Alternatively if someone can make a macro that just fixes all items (specifically that don't already have activities named Two-handed, Offhand or Thrown attacks) that could be shipped with RSR for those that just want to 'fix' their weapons

Describe alternatives you've considered Fixing this shit manually by adding activities when it comes up.

Additional context Add any other context or screenshots about the feature request here.

maxobremer commented 2 hours ago

Btw this could be expanded upon by adding activities for weapon masteries, though I see that as a bit outside of the scope of this module, though if a script/macro is made for this issue, I imagine its not that much of an extra step to solve another issue

maxobremer commented 2 hours ago

and since this might not require much of RSR code maybe @jagoe is up to it since they did mention wanting to help out? IDK just a suggestion/idea

MangoFVTT commented 2 hours ago

Generating new activities is a bit beyond the scope of RSR as a module, though it should be not too difficult to create a macro that auto-generates activities for you for weapons that have multiple attack modes. I suspect that the attack modes workflow will be revised at some point, because right now it is, as you said, quite a pain.

maxobremer commented 2 hours ago

tbh I am kinda surprised the dnd team decided to go for this route of putting it in the attack roll dialogue.

I suspect that the attack modes workflow will be revised at some point As in from the dnd team's side of things? I hope so but do think if they are gonna take that step its gonna be with some automations like discussed on their github page which will probably take some time

MangoFVTT commented 1 hour ago

It was definitely a strange choice. Many activities require far too much clicking to get the desired result as it stands, but that appears to be the general consensus so I'm sure it will get improved on

jagoe commented 1 hour ago

@maxobremer Hit me up on Discord (celtsfightnude) and I'll see what I can do. I agree that something like this probably shouldn't be in a module like RSR, but I'll look into creating a macro.

MangoFVTT commented 1 hour ago

In that case, closing this ticket as "won't do", since it should be handled outside this module 👍