search

MangoFVTT / fvtt-ready-set-roll-5e

A module for faster, easier, and more dynamic rolling in the D&D 5th Edition system for Foundry VTT.
GNU General Public License v3.0
43 stars 21 forks source link

[BUG] RSR does not create chat cards for Utility Activities #512

Closed asherett closed 1 month ago

asherett commented 1 month ago

Description RSR does not create any chat card when rolling Utility Activities that don't have rolls.

Steps to Reproduce

  1. Click on an item that only has a Utility Activity
  2. See no chat card being created
  3. If you hold down shift to bypass RSR, a chat card is created.

Versions

Other Modules Issue exists with RSR as only active module

nschoenwald commented 1 month ago

Came here to report this. I had this issue with the Bless spell.

MangoFVTT commented 1 month ago

Issue resolved in next release.

nschoenwald commented 1 month ago

I just had my first session with dnd v4 and Ready Set Roll and I still had issues with some utility activities not outputting a chat card. This seemed to mostly occur for cards with no roll attached at all, but I can't do deeper testing right now. Module: [3.3.4] dnd5e: [4.0.4] Foundry: [12.331] @MangoFVTT

nschoenwald commented 1 month ago

@MangoFVTT

image
MangoFVTT commented 1 month ago

I haven't been able to reproduce that error, but I've added an extra safety check to prevent it from ever happening. Will be in the next release

nschoenwald commented 1 month ago

I haven't been able to reproduce that error, but I've added an extra safety check to prevent it from ever happening. Will be in the next release

I reproduced it with the War Caster feat, I think it's related to Acitivities without any roll data.

nschoenwald commented 1 month ago

@MangoFVTT The new release has fixed it, thank you so much for the quick support!