MangoFVTT / fvtt-ready-set-roll-5e

A module for faster, easier, and more dynamic rolling in the D&D 5th Edition system for Foundry VTT.
GNU General Public License v3.0
41 stars 20 forks source link

[BUG] When rolling an attack, the Ready-Set-Roll Chatmessage does not appear. #6

Closed Morgeth closed 2 years ago

Morgeth commented 2 years ago

image image

Description Once using the character sheet to activate an attack, the damage roller instead rolls using the old visual style, however automatically rolls the dice regardless. A Chat message matching the message displayed in the readme, is not present at any point.

Steps to Reproduce

  1. Install using the Client search function.
  2. Activate on world
  3. Roll basic weapon or spell attack

Versions

Morgeth commented 2 years ago

Ive come to realise that the roll infact have the correct appearance however it does not automatically roll for the damage of the dice, bringing up the option to choose between critical and normal hit. If the button is pressed then it proceeds as normal. Not sure if that is intended or not. If it is, then I misunderstood. :)

MangoFVTT commented 2 years ago

@Morgeth it seems like you may have accidentally triggered the default roll dialog in some fashion. Are you clicking the item's image to trigger the quick roll? And can you confirm if the Enable Quick Rolls for Items setting is active and you are not holding alt?

image

Morgeth commented 2 years ago

image Enable quick Roll for items is active. Not pressing alt,

I am using the Tidy5e sheet and pressing the image in order to activate the item. image When I do so, It automatically rolls the d20 in order to attack, and immediately gives me the standard damage roll prompt (Example below). During this time, the prompt has the default appearance. image

If I press normal or Critical, then the chat message is updated with the correct appearance image

Morgeth commented 2 years ago

Going by the basis of Better rolls, I presume that the damage is meant to roll automatically rather than giving me the prompt for normal or critical damage?

MangoFVTT commented 2 years ago

That is correct, however I haven't tested this module in conjunction with any other modules just yet, and I don't use TidySheet5e myself personally. I will investigate this to see what the issue might be

MangoFVTT commented 2 years ago

@Morgeth I tested this out with TidySheet and was unable to reproduce the errors you are getting. Are you still having the problem? If yes, what other modules do you have installed and do any of them interact with dice rolls?

Further to that, if you are not having this problem with every item, exporting the items that you are having the issue on and posting them here so I can take a look at their data would be very helpful.

TidySheet

Morgeth commented 2 years ago

Hello again Mango, sorry for not replying back yesterday but I wanted to get some further research done into it myself so I could come back with more concrete information on what is causing it.

I managed to find the issue, namely the thing causing the error was when the plugin was used in conjunction with Midi-QoL. Midi QoL has an QoL change for rolling automation that ends up conflicting with the plugin. When the option is disabled, the dice works as expected. image

image

MangoFVTT commented 2 years ago

Ah that explains it. Midi QOL modifies the same functions as this module, so you cannot use both in conjunction (for dice automation). You have to pick one or the other. Hope that helps you solve the issue 😄