MangoIV / dracuLad

QMK-powered 34-36 key split keyboard
204 stars 18 forks source link

Both rotary encoders are assigned the same functionality in current qmk default keymap #15

Open joachimmathes opened 4 months ago

joachimmathes commented 4 months ago

When I flashed my draculad over a year ago both rotary encoders worked as expected with a customized callback function encoder_update_user(). But when I lately switched to the new qmk setup with separated qmk_firmware and qmk_userspace weird encoder behavior occurred. So I tried the default keymap with

qmk flash --keyboard draculad -km default

on commit https://github.com/qmk/qmk_firmware/commit/1fa84ea83c68bb24bc6b21c5abc376ee12d1b939 What happens is, that the left encoder works as expected: VOLD/VOLD. But the right encoder has the mirrored assignment (VOLU/VOLD). According to https://github.com/qmk/qmk_firmware/blob/1fa84ea83c68bb24bc6b21c5abc376ee12d1b939/keyboards/draculad/keymaps/default/keymap.c#L201 it should trigger PGDN/PGUP.

I haven't found the reason, yet.

Do you run into the same behavior?

natskis commented 2 weeks ago

Has this worked for you? My draculad is doing the same thing. Just inverting and executing VOLU/VOLD.

I'm wondering if it's because you need to use the split keyboard functions and it's not reading that it's on the right side of the draculad... I am a total newb at this though so very unsure and a bit confused

https://docs.qmk.fm/features/encoders#split-keyboards