search

Mangopay / mangopay

MANGOPAY API Known Issues
3 stars 2 forks source link

Typo in "RessourceId" param for hooks #23

Closed javiercr closed 8 years ago

javiercr commented 8 years ago

The current implementation of Hooks make requests to servers with the following params:

This is defined in the docs:

Notification format: http://www.your-site.com?EventType=`EventId`&RessourceId=`ResourceId`&Date=`Timestamp``

However RessourceID is misspelled and it's not consistent with the Event object which has ResourceId (single s) as attribute.

I understand changing this now it may be problematic (our own app is already expecting the param with the typo). I think a mention about the typo in the documentation would be helpful for future users.

PS: this reminds me a lot to the famous typo in the HTTP header referer.

hobailey commented 8 years ago

Thanks for flagging this up @javiercr - I've just added a note in the docs to highlight this more clearly :-) As you say, not something that is easily correctable without a new API version sadly.

javiercr commented 8 years ago

Kudos for adding that note so quick! 💪