search

Mangopay / mangopay2-php-sdk

PHP SDK for MANGOPAY
https://packagist.org/packages/mangopay/php-sdk-v2
MIT License
123 stars 134 forks source link

Adjusted ApiUsers::CreateKycPage() return type documentation being misleading #416

Closed LANGERGabrielle closed 3 years ago

LANGERGabrielle commented 4 years ago

ApiUsers::CreateKycPage() states it can return false, but a quick glance at the possible code paths shows that it either returns true or throws.

Since all code paths that returns returns true, we can also simplify the code.

SoloJr commented 3 years ago

Hi @LANGERGabriel

Sorry for the late reply. I'll merge your PR, thanks for the contribution. We've decided to go only with PHP 7.2 in the travis.yml file, that's the only reason the PR is failing for this, but once merged, it will work as a charm.

Thank you!