search

Mangopay / mangopay2-php-sdk

PHP SDK for MANGOPAY
https://packagist.org/packages/mangopay/php-sdk-v2
MIT License
122 stars 133 forks source link

Improved documentation around ubo declaration reason. #419

Closed LANGERGabrielle closed 3 years ago

LANGERGabrielle commented 4 years ago

UboDeclarationRefusedReasonType was not exhaustive and it's name was confusing (It implied that a an incomplete ubo declaration has no Reason, which contradicts the examples given in the documentation).

Deprecated UboDeclarationRefusedReasonType to maintain BC while redirecting users to the more correct UboDeclarationRefusedOrIncompleteReasonType.

mangomaxoasis commented 3 years ago

Hi @langergabriel Could you rebase your PR to master, we've made some changes to the testing and release process Hence this PR won't pass unless it is up to date with current master thanks

LANGERGabrielle commented 3 years ago

@mangomaxoasis Done. It seems that there are still unrelated issues with travis. I can rebase again if needed.

Thank you.

mangomaxoasis commented 3 years ago

Hi @LANGERGabriel Thanks for that, yes the Travis was out of action lately. We'll release shortly max