search

Mangopay / mangopay2-php-sdk

PHP SDK for MANGOPAY
https://packagist.org/packages/mangopay/php-sdk-v2
MIT License
122 stars 133 forks source link

3D-Secure 2.0 - PayIn Missing Fields #465

Closed laurent-bientz closed 3 years ago

laurent-bientz commented 3 years ago

Hello,

According to the implementation for 3D-Secure 2.0, we should add BrowserInfo, IpAddress, Billing & Shipping objects to:

For CardPreAuthorization object, the SDK almost reflects (see #459) the API call (based on the fact Billing & Shipping are optional, I'm suppose it should work without passing them to the API...)

For PayIn object, I can't see any of the asked properties (BrowserInfo, IpAddress, Billing & Shipping) in the current SDK.

Even in sub PaymentDetails (PayInPaymentDetailsPreAuthorized in my case), there is no possibility at all to pass the required informations.

How can we adapt the API calls without having a SDK up to date? Can we have a rlz date for a new version of the SDK? We need to have time to perform the changes and testing them before the end of March.

2nd question: if my PayIn is based on a PreAuthorization (on which I've attached BrowserInfo and IpAddress), do we have to pass again these informations during the API call or you're able to recover automatically them from the PreAuth?

Thanks in advance

dduwoyemgp commented 3 years ago

Hello @laurent-bientz Thank you for sharing this issue with us. We are working on a new release and I hope it could land this week. About your second question, we'll look into it.

laurent-bientz commented 3 years ago

Hello @dduwoyemgp

Thanks for the new release that allows to pass the correct informations for CardPreAuthorization (including FirstName & LastName).

About PayIn object or sub PayInPaymentDetailsPreAuthorized, I can't see any Billing, Shipping, BrowserInfo or IpAddress.

Do I assume all these fields are not required to be passed in the case of a PayIn triggered by a PreAuth?

I guess that because for a standard PaymentDetails (aka PayInPaymentDetailsCard) we get almost all the fields? (don't understand why Billing is missing but whatever).

dduwoyemgp commented 3 years ago

Hello @laurent-bientz

You assumed well because as you said, all these fields are not mandatory in the case of a PayIn triggered by a PreAuth

laurent-bientz commented 3 years ago

@dduwoyemgp great, thanks for your feedback! We can close.