Mangopay / mangopay2-php-sdk

PHP SDK for MANGOPAY
https://packagist.org/packages/mangopay/php-sdk-v2
MIT License
123 stars 134 forks source link

Updating Already added bank details causing the account to be inactive #512

Closed piyushfreeads closed 3 years ago

piyushfreeads commented 3 years ago

When a user has added a bank account in mango pay it may so happen that there could be some typing mistake with name etc. So we are allowing user tp edit the bank details. We are using PHP SDK and when using the UpdateBankAccount function of the users object it is not updating the details rather making the bank account active does that mean we cannot update the bank details once added or this is a BUG. The Active attribute of bank object can only be set to False. if set o true will end up in error.

H4wKs commented 3 years ago

Hi @piyushfreeads, I would double check with MangoPay support, but from my understanding, you can't update a bank account object, and this is not a limitation of the PHP SDK. According to the MangoPay API Doc, ( https://docs.mangopay.com/endpoints/v2.01/bank-accounts#e24_the-bankaccount-object ) you can only create, list, view, desactivate a bank account object. The problem here is that the PHP SDK method name UpdateBankAccount is miss leading, because what this method do is calling the bank account desactivate URL ( https://docs.mangopay.com/endpoints/v2.01/bank-accounts#e306_deactivate-a-bank-account ). We have the same issue when it's come to registered cards.

fredericdelordm commented 3 years ago

Hello @piyushfreeads,

You can't update a bankAccount. You need to deactivate the old one and submit a new one with the new data.

hello @H4wKs, thank you for the feedback. We will update it soon.

piyushfreeads commented 3 years ago

Thanks for update.