Mangopay / mangopay2-php-sdk

PHP SDK for MANGOPAY
https://packagist.org/packages/mangopay/php-sdk-v2
MIT License
123 stars 134 forks source link

Docs misleading for Rate Limiting #549

Closed chrs-myrs closed 1 year ago

chrs-myrs commented 2 years ago

The main readme suggests that $rateLimit->ResetTimeTimestamp contains the number of milliseconds until the limit reset. This is evidently wrong and contradicts the information in the API and PHPDoc documentation. My code is currently waiting 19 days between each call :laughing:

fredericdelordm commented 2 years ago

Hello @chrs-myrs,

Thanks for the feedback, we are going to fix this readme.

iulian03 commented 1 year ago

Hi @chrs-myrs,

I'm not sure I understand your issue. The current Readme and docs state that $ResetTimeTimestamp represents the time in unix timestamp WHEN the number of allowed calls in this time interval will be reset , and NOT the number of milliseconds until the limit reset.

Could you please clarify?

Thanks!